Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261407AbVAGN1t (ORCPT ); Fri, 7 Jan 2005 08:27:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261406AbVAGN1t (ORCPT ); Fri, 7 Jan 2005 08:27:49 -0500 Received: from mail.tv-sign.ru ([213.234.233.51]:32234 "EHLO several.ru") by vger.kernel.org with ESMTP id S261407AbVAGN1q (ORCPT ); Fri, 7 Jan 2005 08:27:46 -0500 Message-ID: <41DE9D10.B33ED5E4@tv-sign.ru> Date: Fri, 07 Jan 2005 17:30:40 +0300 From: Oleg Nesterov X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.20 i686) X-Accept-Language: en MIME-Version: 1.0 To: Linus Torvalds Cc: William Lee Irwin III , linux-kernel@vger.kernel.org Subject: Re: Make pipe data structure be a circular list of pages, rather than Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 26 Hello. pipe_writev: > + if (bufs < PIPE_BUFFERS) { > + ssize_t chars; > + int newbuf = (info->curbuf + bufs) & (PIPE_BUFFERS-1); If i understand this patch correctly, then this code for (;;) write(pipe_fd, &byte, 1); will block after writing PIPE_BUFFERS == 16 characters, no? And pipe_inode_info will use 64K to hold 16 bytes! Is it ok? May be it make sense to add data to the last allocated page until buf->len > PAGE_SIZE ? Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/