Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261682AbVAGW4k (ORCPT ); Fri, 7 Jan 2005 17:56:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261679AbVAGWzr (ORCPT ); Fri, 7 Jan 2005 17:55:47 -0500 Received: from pfepa.post.tele.dk ([195.41.46.235]:13829 "EHLO pfepa.post.tele.dk") by vger.kernel.org with ESMTP id S261686AbVAGWzb (ORCPT ); Fri, 7 Jan 2005 17:55:31 -0500 Date: Fri, 7 Jan 2005 23:56:31 +0100 From: Sam Ravnborg To: linux-os@analogic.com Cc: Geert Uytterhoeven , Marcelo Tosatti , Linux Kernel Development , linux-net@vger.kernel.org Subject: Re: [PATCH 167] Kill unused variables in the net code Message-ID: <20050107225631.GA21884@mars.ravnborg.org> Mail-Followup-To: linux-os@analogic.com, Geert Uytterhoeven , Marcelo Tosatti , Linux Kernel Development , linux-net@vger.kernel.org References: <200501072111.j07LB4EN011223@anakin.of.borg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 557 Lines: 16 On Fri, Jan 07, 2005 at 04:38:36PM -0500, linux-os wrote: > >-#define read_unlock(lock) do { } while(0) > >+#define read_unlock(lock) (void)(lock) /* Not "unused variable". */ > > But don't all you need to do is: > > #define read_unlock(x) Then tbl will still be unused - and compiler will emit warning. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/