Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261723AbVAHAW4 (ORCPT ); Fri, 7 Jan 2005 19:22:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261722AbVAHAUK (ORCPT ); Fri, 7 Jan 2005 19:20:10 -0500 Received: from stat16.steeleye.com ([209.192.50.48]:48611 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S261713AbVAGXTz (ORCPT ); Fri, 7 Jan 2005 18:19:55 -0500 Subject: Re: [PATCH 2.6] cciss typo fix From: James Bottomley To: mike.miller@hp.com Cc: Andrew Morton , Jens Axboe , Linux Kernel , SCSI Mailing List In-Reply-To: <20050107230103.GB26037@beardog.cca.cpqcorp.net> References: <20050107230103.GB26037@beardog.cca.cpqcorp.net> Content-Type: text/plain Date: Fri, 07 Jan 2005 18:19:28 -0500 Message-Id: <1105139968.4151.26.camel@mulgrave> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 (2.0.2-3) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 23 On Fri, 2005-01-07 at 17:01 -0600, mike.miller@hp.com wrote: > - *total_size = be32_to_cpu(*((__be32 *) &buf->total_size[0]))+1; > - *block_size = be32_to_cpu(*((__be32 *) &buf->block_size[0])); > + *total_size = be32_to_cpu(*((__u32 *) &buf->total_size[0]))+1; > + *block_size = be32_to_cpu(*((__u32 *) &buf->block_size[0])); I don't think that's a typo. It was introduced by this patch: ChangeSet 1.1988.24.79 2004/10/06 07:55:02 viro@www.linux.org.uk [PATCH] cciss endianness and iomem annotations The idea being that BE and LE numbers should be annotated differently, so the __be32 annotations look correct to me. I think sparse will warn if you make this change. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/