Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261648AbVAIQpJ (ORCPT ); Sun, 9 Jan 2005 11:45:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261559AbVAIQpJ (ORCPT ); Sun, 9 Jan 2005 11:45:09 -0500 Received: from one.firstfloor.org ([213.235.205.2]:46270 "EHLO one.firstfloor.org") by vger.kernel.org with ESMTP id S261663AbVAIQo4 (ORCPT ); Sun, 9 Jan 2005 11:44:56 -0500 To: Zwane Mwaikambo Cc: Andrew Morton , Linux Kernel Subject: Re: [PATCH] x86_64: Notify user of MCE events. References: From: Andi Kleen Date: Sun, 09 Jan 2005 17:44:54 +0100 In-Reply-To: (Zwane Mwaikambo's message of "Sat, 8 Jan 2005 21:29:41 -0700 (MST)") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 30 Zwane Mwaikambo writes: > + > + if (!test_and_set_bit(0, &console_logged)) > + notify_user = 1; > } > > static void print_mce(struct mce *m) > @@ -252,6 +258,12 @@ static void mcheck_timer(void *data) > { > on_each_cpu(mcheck_check_cpu, NULL, 1, 1); > schedule_delayed_work(&mcheck_work, check_interval * HZ); > + > + if (notify_user && console_logged) { Perhaps a comment here that the race is harmless? > + notify_user = 0; > + clear_bit(0, &console_logged); > + printk(KERN_EMERG "Machine check exception logged, run mcelog\n"); I would drop the "run mcelog". It's misleading if mcelog is already running in cron as it should. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/