Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261659AbVAISON (ORCPT ); Sun, 9 Jan 2005 13:14:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261663AbVAISON (ORCPT ); Sun, 9 Jan 2005 13:14:13 -0500 Received: from one.firstfloor.org ([213.235.205.2]:52414 "EHLO one.firstfloor.org") by vger.kernel.org with ESMTP id S261659AbVAISOL (ORCPT ); Sun, 9 Jan 2005 13:14:11 -0500 To: Zwane Mwaikambo Cc: Andrew Morton , Linux Kernel Subject: Re: [PATCH] x86_64: Notify user of MCE events (updated) References: From: Andi Kleen Date: Sun, 09 Jan 2005 19:14:09 +0100 In-Reply-To: (Zwane Mwaikambo's message of "Sun, 9 Jan 2005 10:10:11 -0700 (MST)") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 737 Lines: 20 Zwane Mwaikambo writes: > + */ > + if (notify_user && console_logged) { > + notify_user = 0; > + clear_bit(0, &console_logged); > + printk(KERN_EMERG "Machine check exception logged\n"); Another suggestion: don't make this KERN_EMERG. Make it KERN_INFO. Logged errors are usually correct, so there is no need for an emergency. Also since these are not always exceptions (but can be read from the polling timer) I would call them "machine check events" -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/