Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261681AbVAIS1k (ORCPT ); Sun, 9 Jan 2005 13:27:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261685AbVAIS1k (ORCPT ); Sun, 9 Jan 2005 13:27:40 -0500 Received: from fsmlabs.com ([168.103.115.128]:45219 "EHLO fsmlabs.com") by vger.kernel.org with ESMTP id S261681AbVAIS1i (ORCPT ); Sun, 9 Jan 2005 13:27:38 -0500 Date: Sun, 9 Jan 2005 11:27:20 -0700 (MST) From: Zwane Mwaikambo To: Andi Kleen cc: Andrew Morton , Linux Kernel Subject: Re: [PATCH] x86_64: Notify user of MCE events (updated) In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 23 On Sun, 9 Jan 2005, Andi Kleen wrote: > Zwane Mwaikambo writes: > > + */ > > + if (notify_user && console_logged) { > > + notify_user = 0; > > + clear_bit(0, &console_logged); > > + printk(KERN_EMERG "Machine check exception logged\n"); > > Another suggestion: don't make this KERN_EMERG. Make it KERN_INFO. > Logged errors are usually correct, so there is no need for an > emergency. > > Also since these are not always exceptions (but can be read from > the polling timer) I would call them "machine check events" Thanks for the comments, i've updated the patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/