Message-ID: <41E17860.1040100@domdv.de>
Date: Sun, 09 Jan 2005 19:30:56 +0100
From: Andreas Steinmetz <ast@domdv.de>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041207)
MIME-Version: 1.0
To: Andi Kleen <ak@muc.de>
CC: Zwane Mwaikambo <zwane@arm.linux.org.uk>, Andrew Morton <akpm@osdl.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: Notify user of MCE events (updated)
References: <Pine.LNX.4.61.0501082121380.13639@montezuma.fsmlabs.com>	<m1sm5av9fd.fsf@muc.de>	<Pine.LNX.4.61.0501091005590.13639@montezuma.fsmlabs.com> <m1fz1av5am.fsf@muc.de>
In-Reply-To: <m1fz1av5am.fsf@muc.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1006
Lines: 27

Andi Kleen wrote:
> Zwane Mwaikambo <zwane@arm.linux.org.uk> writes:
> 
>>+	 */
>>+	if (notify_user && console_logged) {
>>+		notify_user = 0;
>>+		clear_bit(0, &console_logged);
>>+		printk(KERN_EMERG "Machine check exception logged\n");
> 
> 
> Another suggestion: don't make this KERN_EMERG. Make it KERN_INFO. 
> Logged errors are usually correct, so there is no need for an 
> emergency.

Just asking:
How about KERN_NOTICE? KERN_INFO is in my opinion too easily lost in the 
syslog noise. Personally I'm logging KERN_INFO just to console, 
KERN_NOTICE however to file.
An MCE event would suit the description "normal but significant 
condition" of KERN_NOTICE as far as I can see.
-- 
Andreas Steinmetz                       SPAMmers use robotrap@domdv.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/