Subject: Re: make flock_lock_file_wait static
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Arjan van de Ven <arjan@infradead.org>
Cc: viro@zenII.uk.linux.org, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@osdl.org>
In-Reply-To: <20050109194209.GA7588@infradead.org>
References: <20050109194209.GA7588@infradead.org>
Content-Type: text/plain
Date: Sun, 09 Jan 2005 17:44:10 -0500
Message-Id: <1105310650.11315.19.camel@lade.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 928
Lines: 23

su den 09.01.2005 Klokka 19:42 (+0000) skreiv Arjan van de Ven:
> Hi,
> 
> the patch below makes flock_lock_file_wait static, because it is only used
> (once) in fs/locks.c. Making it static allows gcc to generate better code
> (partial or entirely inlining it, gcc 3.4 also optimizes the calling
> convention for static functions which are guaranteed only local to the file)

Veto. That function is also there for those filesystems that need to
mirror their locks in the VFS. I believe the GFS people are already
using it (they implemented all this anyway), and sooner or later, NFS is
going to have to do it too...

Cheers,
  Trond
-- 
Trond Myklebust <trond.myklebust@fys.uio.no>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/