Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262295AbVAJPvP (ORCPT ); Mon, 10 Jan 2005 10:51:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262298AbVAJPvP (ORCPT ); Mon, 10 Jan 2005 10:51:15 -0500 Received: from 213-239-205-147.clients.your-server.de ([213.239.205.147]:50833 "EHLO debian.tglx.de") by vger.kernel.org with ESMTP id S262295AbVAJPvH (ORCPT ); Mon, 10 Jan 2005 10:51:07 -0500 Message-ID: <53311.212.184.22.162.1105372175.squirrel@www.tglx.de> In-Reply-To: <20050110145615.GC2226@smtp.west.cox.net> References: <20050110013508.1.patchmail@tglx> <1105318804.17853.5.camel@tglx.tec.linutronix.de> <20050110145615.GC2226@smtp.west.cox.net> Date: Mon, 10 Jan 2005 16:49:35 +0100 (CET) Subject: Re: [PATCH 2.6.10-mm2] Use the new preemption code [3/3] From: tglx@linutronix.de To: "Tom Rini" Cc: "Thomas Gleixner" , "Ingo Molnar" , "LKML" , "Andrew Morton" User-Agent: SquirrelMail/1.4.3a X-Mailer: SquirrelMail/1.4.3a MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 37 > On Mon, Jan 10, 2005 at 02:00:04AM +0100, Thomas Gleixner wrote: > >> This patch adjusts the PPC entry code to use the fixed up >> preempt_schedule() handling in 2.6.10-mm2 >> >> Signed-off-by: Thomas Gleixner >> >> --- >> entry.S | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> --- >> Index: 2.6.10-mm1/arch/ppc/kernel/entry.S >> =================================================================== >> --- 2.6.10-mm1/arch/ppc/kernel/entry.S (revision 141) >> +++ 2.6.10-mm1/arch/ppc/kernel/entry.S (working copy) >> @@ -624,12 +624,12 @@ >> beq+ restore >> andi. r0,r3,MSR_EE /* interrupts off? */ >> beq restore /* don't schedule if so */ >> -1: lis r0,PREEMPT_ACTIVE@h >> +1: li r0,1 > > Perhaps I just don't have enough context, but is there good reason to > use a magic constant instead of a define ? > True. I will wait for Ingo's final solution and fix this proper. tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/