Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262304AbVAJPxV (ORCPT ); Mon, 10 Jan 2005 10:53:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262305AbVAJPvn (ORCPT ); Mon, 10 Jan 2005 10:51:43 -0500 Received: from stat16.steeleye.com ([209.192.50.48]:2001 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S262304AbVAJPvY (ORCPT ); Mon, 10 Jan 2005 10:51:24 -0500 Subject: RE: [PATCH 2.6] cciss typo fix From: James Bottomley To: "Miller, Mike (OS Dev)" Cc: Jens Axboe , Andrew Morton , Linux Kernel , SCSI Mailing List In-Reply-To: References: Content-Type: text/plain Date: Mon, 10 Jan 2005 09:50:38 -0600 Message-Id: <1105372238.4477.5.camel@mulgrave> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 (2.0.2-3) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 639 Lines: 16 On Mon, 2005-01-10 at 09:45 -0600, Miller, Mike (OS Dev) wrote: > Even if it were added to the compat header; is using __be32 correct in this context? They should be. The __be annotations track unconverted big endian numbers. be32_to_cpu checks that it's only taking __be annotated variables (at least when sparse tracks it), so the cast is correct and prevents sparse from warning. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/