DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
        b=OJZWDyeYs8XEgXH4L7gLZvhVcgxWom53cna+7KSb5piGu9xQgFJqn0LnViUoSwwM7O8C98IwpW5GOpWms3lAAtHPZytyWjG4OnUDtF/uCYmKW0QBxYE1hPc0B1QaRzN9GSN819TR9Hnl6p0gQSmQGUi1Fqn6Oj60LtSbkk2JX10=
Message-ID: <4d6522b90501101517420fced6@mail.gmail.com>
Date: Tue, 11 Jan 2005 01:17:01 +0200
From: Edjard Souza Mota <edjard@gmail.com>
Reply-To: Edjard Souza Mota <edjard@gmail.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: Re: User space out of memory approach
Cc: Mauricio Lin <mauriciolin@gmail.com>, linux-kernel@vger.kernel.org,
       akpm@osdl.org
In-Reply-To: <20050110200514.GA18796@logos.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <3f250c71050110134337c08ef0@mail.gmail.com>
	 <20050110192012.GA18531@logos.cnet>
	 <4d6522b9050110144017d0c075@mail.gmail.com>
	 <20050110200514.GA18796@logos.cnet>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1141
Lines: 42

Hi,

> 
> Sorry, I misunderstood. Should have read the code before shouting.

Better shouting then shooting :)!

br

Edjard


> 
> The feature is interesting - several similar patches have been around with similar
> functionality (people who need usually write their own, I've seen a few), but none
> has ever been merged, even though it is an important requirement for many users.
> 
> This is simple, an ordered list of candidate PIDs. IMO something similar to this
> should be merged. Andrew ?
> 
> Few comments about the code:
> 
>  retry:
> -       p = select_bad_process();
> +       printk(KERN_DEBUG "A good walker leaves no tracks.\n");
> +       p = select_process();
> 
> You want to fallback to select_bad_process() if no candidate has been selected at
> select_process().
> 
> You also want to move "oom" to /proc/sys/vm/.
> 
> 


-- 
"In a world without fences ... who needs Gates?"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/