Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262766AbVAKOPx (ORCPT ); Tue, 11 Jan 2005 09:15:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262767AbVAKOPw (ORCPT ); Tue, 11 Jan 2005 09:15:52 -0500 Received: from aun.it.uu.se ([130.238.12.36]:15311 "EHLO aun.it.uu.se") by vger.kernel.org with ESMTP id S262766AbVAKOPr (ORCPT ); Tue, 11 Jan 2005 09:15:47 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16867.57217.358323.945559@alkaid.it.uu.se> Date: Tue, 11 Jan 2005 15:15:29 +0100 From: Mikael Pettersson To: Pavel Machek Cc: Mikael Pettersson , Bernard Blackham , Shaw , linux-kernel@vger.kernel.org Subject: Re: Screwy clock after apm suspend In-Reply-To: <20050111131019.GA1324@openzaurus.ucw.cz> References: <7bb8b8de05010710085ea81da9@mail.gmail.com> <20050109224711.GF1353@elf.ucw.cz> <200501092328.54092.shawv@comcast.net> <20050110074422.GA17710@mussel> <20050110105759.GM1353@elf.ucw.cz> <20050110174804.GC4641@blackham.com.au> <20050111001426.GF1444@elf.ucw.cz> <20050111011611.GE4641@blackham.com.au> <16867.51258.916944.195917@alkaid.it.uu.se> <20050111131019.GA1324@openzaurus.ucw.cz> X-Mailer: VM 7.17 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 31 Pavel Machek writes: > Hia > > > > Looking harder, in arch/i386/kernel/apm.c the system time is also > > > saved and restored in a very similar way to timer_suspend/resume. > > > Would this account for the time drift in APM mode? (sleep time being > > > accounted for twice?) > > > > No, apm.c's update to xtime is absolute, just like time.c's. > > Doing both is pointless but not harmful. (I've already tried > > with apm.c's xtime update commented out, but the time-warp > > bug remained.) > > > > My 0.02 SEK says it's the jiffies update that's broken. > > Okay, can you > > * kill jiffie update (x86-64, too) > * remove apm.c variant > * test it (or make someone test it) with apm? > > I now see the drift with acpi, too :-(. I can do the acpi testing... I'm away from my APM laptop until Friday, but I'll do this test then. /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/