Subject: [PATCH] missing dependency for drivers/net/tun.c
From: Steve French <smfltc@us.ibm.com>
To: maxk@qualcomm.com, linux-kernel@vger.kernel.org
Cc: underley@underley.eu.org
Content-Type: multipart/mixed; boundary="=-haeYdBlFrhztqGnfrFAh"
Organization: IBM - Linux Technology Center
Message-Id: <1105477572.12905.16.camel@stevef95.austin.ibm.com>
Mime-Version: 1.0
Date: 11 Jan 2005 15:06:12 -0600
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1633
Lines: 49


--=-haeYdBlFrhztqGnfrFAh
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

drivers/net/tun.c has a missing dependency on enabling the crc32
libraries in kernel config.   With tun enabled and crc32 disabled "make
bzImage" (the linking step) fails. For example:

drivers/built-in.o(.text+0x656f1): In function `add_multi':
linux-2.5cifs/drivers/net/tun.c:112: undefined reference to `crc32_le'
drivers/built-in.o(.text+0x656f9):linux-2.5cifs/drivers/net/tun.c:112:
undefined reference to `bitreverse'

Line 112:

	        int bit_nr = ether_crc(ETH_ALEN, addr) >> 26;

is a call to the ether_crc macro which maps to the bitreverse function
which is only exported if you enable:
	library functions -> CRC32 functions 
in kernel config.  The following would fix it.


--=-haeYdBlFrhztqGnfrFAh
Content-Disposition: attachment; filename=tun-config.patch
Content-Type: text/plain; name=tun-config.patch; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

--- drivers/net/Kconfig.old	2005-01-11 14:59:51.540023800 -0600
+++ drivers/net/Kconfig	2005-01-11 15:00:48.126421360 -0600
@@ -84,6 +84,7 @@
 config TUN
 	tristate "Universal TUN/TAP device driver support"
 	depends on NETDEVICES
+	select CRC32
 	---help---
 	  TUN/TAP provides packet reception and transmission for user space
 	  programs.  It can be viewed as a simple Point-to-Point or Ethernet

--=-haeYdBlFrhztqGnfrFAh--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/