Date: Wed, 12 Jan 2005 21:06:11 +0100
From: Domen Puncer <domen@coderock.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@zip.com.au>,
       kernel list <linux-kernel@vger.kernel.org>
Subject: Re: swsusp: more small fixes
Message-ID: <20050112200611.GM4978@nd47.coderock.org>
References: <20050112131010.GA1378@elf.ucw.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050112131010.GA1378@elf.ucw.cz>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1303
Lines: 46

On 12/01/05 14:10 +0100, Pavel Machek wrote:
> Hi!
> 
> This adds few missing statics to swsusp.c, prints errors even when
> non-debugging and fixes last "pmdisk: " message. Fixed few comments. 
> Please apply,

Some nitpicking...
> 
> --- clean/kernel/power/swsusp.c	2005-01-12 11:07:40.000000000 +0100
> +++ linux/kernel/power/swsusp.c	2005-01-12 11:35:42.000000000 +0100
> @@ -420,7 +419,7 @@
>  	struct highmem_page *next;
>  };
>  
> -struct highmem_page *highmem_copy = NULL;
> +static struct highmem_page *highmem_copy = NULL;

You could remove explicit initialization (so pointer would go into bss
instead of data, IIRC).


> @@ -753,21 +753,21 @@
>  		return -ENOSPC;
>  
>  	if ((error = alloc_pagedir())) {
> -		pr_debug("suspend: Allocating pagedir failed.\n");
> +		printk("suspend: Allocating pagedir failed.\n");

Missing KERN_ constant.

>  		return error;
>  	}
>  	if ((error = alloc_image_pages())) {
> -		pr_debug("suspend: Allocating image pages failed.\n");
> +		printk("suspend: Allocating image pages failed.\n");

Same here.


	Domen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/