From: Jesse Barnes <jbarnes@engr.sgi.com>
To: John Rose <johnrose@austin.ibm.com>
Subject: Re: [PATCH] release_pcibus_dev() crash
Date: Wed, 12 Jan 2005 16:55:42 -0800
User-Agent: KMail/1.7.1
Cc: Greg KH <greg@kroah.com>, lkml <linux-kernel@vger.kernel.org>
References: <1105576756.8062.17.camel@sinatra.austin.ibm.com>
In-Reply-To: <1105576756.8062.17.camel@sinatra.austin.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200501121655.42947.jbarnes@engr.sgi.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 852
Lines: 19

On Wednesday, January 12, 2005 4:39 pm, John Rose wrote:
> The removal of the class device from sysfs is carried out explicitly by
> class_device_del(), which occurs prior to class_device_put().  The class
> device is gone from sysfs by the time class_device_put() is called.  As
> such, this release function should not carry out sysfs cleanups for the
> class device.
>
> I'm unsure how pci_remove_legacy_files() doesn't cause the same crash for
> those who implemented it, but I'll leave that alone for now.

Feel free to fix it too.  I haven't tested the removal case, so thanks for 
catching it.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/