Date: Wed, 12 Jan 2005 22:01:47 +0100
From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andi Kleen <ak@suse.de>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       ncunningham@linuxmail.org
Subject: Re: 2.6.10-mm2: swsusp regression [update]
Message-ID: <20050112210147.GJ1408@elf.ucw.cz>
References: <20050106002240.00ac4611.akpm@osdl.org> <200501081610.57625.rjw@sisk.pl> <20050108154439.GA24771@elf.ucw.cz> <200501121951.48102.rjw@sisk.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200501121951.48102.rjw@sisk.pl>
User-Agent: Mutt/1.5.6+20040907i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1191
Lines: 35

Hi!

> [-- snip --]
> > > > > The regression is caused by the timer driver.  Obviously, turning 
> > > > > timer_resume() in arch/x86_64/kernel/time.c into a NOOP makes it go
> > > > > away. 
> [-- snip --]
> > > > 
> > > > ..you might want to look at i386 time code, they have common
> > > > ancestor, and i386 one seems to work.
> 
> Well, I've changed timer_resume() in arch/x86_64/kernel/time.c into the 
> following function:

Ugh, looking at arch/i386/kernel/time.c... "This could have never
worked".

It does something like get_cmos_time() - get_cmos_time()*HZ. It looks
seriously wrong.

> (for example - the second number is always negative and huge).  Would it mean 
> that get_cmos_time() needs fixing?

get_cmos_time() looks okay, but timer){suspend,resume} looks
hopelessly broken.

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/