Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262008AbVANPbb (ORCPT ); Fri, 14 Jan 2005 10:31:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262009AbVANPbb (ORCPT ); Fri, 14 Jan 2005 10:31:31 -0500 Received: from scrub.xs4all.nl ([194.109.195.176]:3775 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S262008AbVANPba (ORCPT ); Fri, 14 Jan 2005 10:31:30 -0500 Date: Fri, 14 Jan 2005 16:31:18 +0100 (CET) From: Roman Zippel X-X-Sender: roman@scrub.home To: Karim Yaghmour cc: Andi Kleen , Nikita Danilov , linux-kernel@vger.kernel.org, Tom Zanussi Subject: Re: 2.6.11-rc1-mm1 In-Reply-To: <41E7A7A6.3060502@opersys.com> Message-ID: References: <20050114002352.5a038710.akpm@osdl.org> <20050114103836.GA71397@muc.de> <41E7A7A6.3060502@opersys.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 27 Hi, On Fri, 14 Jan 2005, Karim Yaghmour wrote: > Andi Kleen wrote: > > When you have a timing bug and your logger starts to block randomly > > you also won't debug anything. Fix is to make your buffers bigger. > > relayfs allows you to choose which is best for you. > > >From Documentation/filesystems/relayfs.txt: > ... > int relay_open(channel_path, bufsize, nbufs, channel_flags, > channel_callbacks, start_reserve, end_reserve, > rchan_start_reserve, resize_min, resize_max, mode, > init_buf, init_buf_size) You don't think that's a little overkill? BTW it should return a pointer not an id, at every further access it needs to be looked up, killing the effects of any lockless mechanism. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/