Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262119AbVANUt2 (ORCPT ); Fri, 14 Jan 2005 15:49:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262089AbVANUt2 (ORCPT ); Fri, 14 Jan 2005 15:49:28 -0500 Received: from pfepa.post.tele.dk ([195.41.46.235]:33412 "EHLO pfepa.post.tele.dk") by vger.kernel.org with ESMTP id S262119AbVANUtS (ORCPT ); Fri, 14 Jan 2005 15:49:18 -0500 Date: Fri, 14 Jan 2005 21:49:57 +0100 From: Sam Ravnborg To: Karim Yaghmour Cc: Andrew Morton , linux-kernel , LTT-Dev Subject: Re: [PATCH 4/8 ] ltt for 2.6.10 : fs/ events Message-ID: <20050114204957.GB8385@mars.ravnborg.org> Mail-Followup-To: Karim Yaghmour , Andrew Morton , linux-kernel , LTT-Dev References: <41E76288.2080004@opersys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41E76288.2080004@opersys.com> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 615 Lines: 22 Hi Karim. > void __wait_on_buffer(struct buffer_head * bh) > { > + ltt_ev_file_system(LTT_EV_FILE_SYSTEM_BUF_WAIT_START, 0, 0, NULL); Pleae use the subsystem name in both function name and constant - like: > + ltt_ev_fs(LTT_EV_FS_BUF_WAIT_START, 0, 0, NULL); This is commonly practice. Comment is relevant for: file_system => fs network => net memory => mm Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/