Date: Fri, 14 Jan 2005 18:25:40 -0800
From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Han Boetes <han@mijncomputer.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: propolice support for linux
Message-ID: <20050115022540.GA85319@gaz.sfgoth.com>
References: <20050113134620.GA14127@boetes.org> <20050113140446.GA22381@infradead.org> <20050113163733.GB14127@boetes.org> <20050114042542.GB64314@gaz.sfgoth.com> <20050114103051.GJ14127@boetes.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050114103051.GJ14127@boetes.org>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 639
Lines: 18

Last nitpicks, I swear:

Han Boetes wrote:
> +    panic("propolice detects %x at function %s.\n", damaged, func);

You don't need the "\n" at the end - panic() already includes a newline
Most panic() messages don't seem to have punctuation either so you can
probably lose the "." too.

Also it's nice to use "0x%X" to print hex numbers so they don't ever
get misinterpreted as decimals.

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/