Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262338AbVAOWGt (ORCPT ); Sat, 15 Jan 2005 17:06:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262330AbVAOWFF (ORCPT ); Sat, 15 Jan 2005 17:05:05 -0500 Received: from news.suse.de ([195.135.220.2]:60630 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S262338AbVAOWBw (ORCPT ); Sat, 15 Jan 2005 17:01:52 -0500 Date: Sat, 15 Jan 2005 23:01:51 +0100 From: Andi Kleen To: linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: slab.c use of __get_user and sparse Message-ID: <20050115220151.GA16442@wotan.suse.de> References: <20050115213906.GA22486@mars.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050115213906.GA22486@mars.ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 17 > Based on the comment it is understood that suddenly this pointer points > to userspace, because the module got unloaded. > I wonder why we can rely on the same address now the module got unloaded - > we may risk this virtual address is taken over by someone else? The address is not user space; you would be lying. Perhaps it's best to get rid of the hack completely. Turn kmem_cache_t->name into an array and copy the name instead of storing the pointer, then it wouldn't be needed at all. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/