Date: Sun, 16 Jan 2005 16:19:04 +1100
From: Anton Blanchard <anton@samba.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: ppc64 xics.c: what is smp_threads_ready exactly used for?
Message-ID: <20050116051904.GP6309@krispykreme.ozlabs.ibm.com>
References: <20050116043356.GM4274@stusta.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050116043356.GM4274@stusta.de>
User-Agent: Mutt/1.5.6+20040907i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 836
Lines: 26

 
Hi,

> during a cleanup, I stumbled upon the following:
> 
> 
> arch/ppc64/kernel/smp.c (in 2.6.11-rc1-mm1) says:
> 
>         /* XXX fix this, xics currently relies on it - Anton */
>         smp_threads_ready = 1;
> 
> 
> arch/ppc64/kernel/xics.c is the _only_ place in the whole kernel where 
> smp_threads_ready is actually used, and this is the _only_ place where 
> smp_threads_ready ever changes it's value on ppc64.

It turns out I was about to submit a patch to remove the ppc64 use of
smp_threads_ready. With that patch it makes sense to kill
smp_threads_ready completely.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/