Date: Mon, 17 Jan 2005 15:40:16 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Chris Wedgwood <cw@f00f.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       LKML <linux-kernel@vger.kernel.org>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id()
Message-ID: <20050117144016.GC10341@elte.hu>
References: <20050117055044.GA3514@taniwha.stupidest.org> <20050117073809.GA3654@taniwha.stupidest.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050117073809.GA3654@taniwha.stupidest.org>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 644
Lines: 17


* Chris Wedgwood <cw@f00f.org> wrote:

> It seems logical that __get_cpu_var should use __smp_processor_id()
> rather than smp_processor_id().  Noticed when __get_cpu_var was making
> lots of noise with CONFIG_DEBUG_PREEMPT=y

no ... normally you should only use __get_cpu_var() if you know that you
are in a non-preempt case. It's a __ internal function for a reason. 
Where did it trigger?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/