From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: hugang@soulinfo.com
Subject: Re: 2.6.10-mm3: swsusp: out of memory on resume (was: Re: Ho ho ho - Linux v2.6.10)
Date: Mon, 17 Jan 2005 16:48:18 +0100
User-Agent: KMail/1.7.1
Cc: linux-kernel@vger.kernel.org
References: <Pine.LNX.4.58.0412241434110.17285@ppc970.osdl.org> <200501161107.24883.rjw@sisk.pl> <20050116144641.GA14825@hugang.soulinfo.com>
In-Reply-To: <20050116144641.GA14825@hugang.soulinfo.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-2"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200501171648.18281.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 28

On Sunday, 16 of January 2005 15:46, hugang@soulinfo.com wrote:
> On Sun, Jan 16, 2005 at 11:07:24AM +0100, Rafael J. Wysocki wrote:
> > > 
> > > I disable Flush TLB after copy page, It speedup the in qemu, But I can't
> > > sure the right thing in real machine, can someone give me point.
> > 
> > Could you, please, make a patch against -rc1-mm1 with your previous patch
> > applied?  It would be much easier to apply. :-)
> > 
> 
> http://soulinfo.com/~hugang/swsusp/2005-1-16/

Actually, there's a bug in your code: in swsusp.c:alloc_one_pagedir() you
should return NULL rather than -ENOMEM.

Greets,
RJW


-- 
- Would you tell me, please, which way I ought to go from here?
- That depends a good deal on where you want to get to.
		-- Lewis Carroll "Alice's Adventures in Wonderland"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/