Date: Mon, 17 Jan 2005 10:53:19 -0800
From: Chris Wedgwood <cw@f00f.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       LKML <linux-kernel@vger.kernel.org>, Paul Mackerras <paulus@samba.org>,
       Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id()
Message-ID: <20050117185319.GA20328@taniwha.stupidest.org>
References: <20050117055044.GA3514@taniwha.stupidest.org> <20050117073809.GA3654@taniwha.stupidest.org> <20050117144016.GC10341@elte.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050117144016.GC10341@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 679
Lines: 14

On Mon, Jan 17, 2005 at 03:40:16PM +0100, Ingo Molnar wrote:

> no ... normally you should only use __get_cpu_var() if you know that
> you are in a non-preempt case. It's a __ internal function for a
> reason.  Where did it trigger?

XFS has statistics which are 'per cpu' but doesn't use per_cpu
variables, __get_cpu_var(foo)++ is used (it doesn't have to be preempt
safe since it's just stats and who cares if they are a bit wrong).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/