Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261401AbVARTaX (ORCPT ); Tue, 18 Jan 2005 14:30:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261402AbVARTaW (ORCPT ); Tue, 18 Jan 2005 14:30:22 -0500 Received: from fw.osdl.org ([65.172.181.6]:59780 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261401AbVARTaQ (ORCPT ); Tue, 18 Jan 2005 14:30:16 -0500 Date: Tue, 18 Jan 2005 11:30:07 -0800 From: Chris Wright To: Stephen Smalley Cc: "Serge E. Hallyn" , Andrew Morton , lkml , James Morris , Chris Wright Subject: Re: [PATCH] Fix audit control message checks Message-ID: <20050118113007.Y24171@build.pdx.osdl.net> References: <20050115200734.GA22087@escher.cs.wm.edu> <1106055058.18274.57.camel@moss-spartans.epoch.ncsc.mil> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <1106055058.18274.57.camel@moss-spartans.epoch.ncsc.mil>; from sds@epoch.ncsc.mil on Tue, Jan 18, 2005 at 08:30:58AM -0500 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1555 Lines: 41 * Stephen Smalley (sds@epoch.ncsc.mil) wrote: > On Sat, 2005-01-15 at 15:07, Serge E. Hallyn wrote: > > The audit control messages are sent over netlink. Permission checks > > are done on the process receiving the message, which may not be the > > same as the process sending the message. This patch switches the > > netlink_send security hooks to calculate the effective capabilities > > based on the sender. Then audit_receive_msg performs capability checks > > based on that. > > > > It also introduces the CAP_AUDIT_WRITE and CAP_AUDIT_CONTROL capabilities, > > and replaces the previous CAP_SYS_ADMIN checks in audit code with the > > appropriate checks. > > > > Please apply. > > > > Changelog: > > 1/15/2005: Simplified dummy_netlink_send given that dummy now > > keeps track of capabilities. > > 1/14/2005: Many fixes based on feedback from linux-audit@redhat.com > > list. > > 1/14/2005: Removed the netlink_msg_type helper function. > > 1/07/2005: Swith to using CAP_AUDIT_WRITE and CAP_AUDIT_CONTROL. > > > > thanks, > > -serge > > > > Signed-off-by: Serge Hallyn > > Signed-off-by: Stephen Smalley Signed-off-by: Chris Wright thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/