Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261469AbVARWst (ORCPT ); Tue, 18 Jan 2005 17:48:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261462AbVARWss (ORCPT ); Tue, 18 Jan 2005 17:48:48 -0500 Received: from mail.kroah.org ([69.55.234.183]:61129 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261466AbVARWsC (ORCPT ); Tue, 18 Jan 2005 17:48:02 -0500 Date: Tue, 18 Jan 2005 14:47:53 -0800 From: Greg KH To: Kylene Hall Cc: linux-kernel@vger.kernel.org, emilyr@us.ibm.com, toml@us.ibm.com, tpmdd-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] tpm: fix cause of SMP stack traces Message-ID: <20050118224753.GA17547@kroah.com> References: <29495f1d041221085144b08901@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 21 On Tue, Jan 18, 2005 at 04:29:23PM -0600, Kylene Hall wrote: > There were misplaced spinlock acquires and releases in the probe, open, > close and release paths which were causing might_sleep and schedule while > atomic error messages accompanied by stack traces when the kernel was > compiled with SMP support. Bug reported by Reben Jenster > Where exactly where the trace errors coming from? I don't see anything in the open path that might have caused it. Anyway, Chris is right, just changing this to _irqsave will not fix the issue. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/