Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261463AbVARXIK (ORCPT ); Tue, 18 Jan 2005 18:08:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261468AbVARXIK (ORCPT ); Tue, 18 Jan 2005 18:08:10 -0500 Received: from e35.co.us.ibm.com ([32.97.110.133]:64510 "EHLO e35.co.us.ibm.com") by vger.kernel.org with ESMTP id S261463AbVARXHy (ORCPT ); Tue, 18 Jan 2005 18:07:54 -0500 Subject: Re: [PATCH 1/1] tpm: fix cause of SMP stack traces From: Kylene Hall To: Greg KH Cc: linux-kernel@vger.kernel.org, Emily Ratliff , Tom Lendacky , tpmdd-devel@lists.sourceforge.net In-Reply-To: <20050118224753.GA17547@kroah.com> References: <29495f1d041221085144b08901@mail.gmail.com> <20050118224753.GA17547@kroah.com> Content-Type: text/plain Message-Id: <1106089670.2324.16.camel@jo.austin.ibm.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Tue, 18 Jan 2005 17:07:50 -0600 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 26 On Tue, 2005-01-18 at 16:47, Greg KH wrote: > On Tue, Jan 18, 2005 at 04:29:23PM -0600, Kylene Hall wrote: > > There were misplaced spinlock acquires and releases in the probe, open, > > close and release paths which were causing might_sleep and schedule while > > atomic error messages accompanied by stack traces when the kernel was > > compiled with SMP support. Bug reported by Reben Jenster > > > > Where exactly where the trace errors coming from? I don't see anything > in the open path that might have caused it. > True the open path was not affected. > Anyway, Chris is right, just changing this to _irqsave will not fix the > issue. Fixing will reissue the patch momentarily. > > thanks, > > greg k-h > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/