Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261643AbVASIGy (ORCPT ); Wed, 19 Jan 2005 03:06:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261639AbVASIGu (ORCPT ); Wed, 19 Jan 2005 03:06:50 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:54975 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S261643AbVASHdq (ORCPT ); Wed, 19 Jan 2005 02:33:46 -0500 From: "Eric W. Biederman" To: Andrew Morton Cc: , Subject: [PATCH 4/29] x86-i8259-shutdown Date: Wed, 19 Jan 2005 0:31:37 -0700 Message-ID: X-Mailer: patch-bomb.pl@ebiederm.dsl.xmission.com In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 49 From: Eric W. Biederman This patch disables interrupt generation from the legacy pic on reboot. Now that there is a sys_device class it should not be called while drivers are still using interrupts. There is a report about this breaking ACPI power off on some systems. http://bugme.osdl.org/show_bug.cgi?id=4041 However the final comment seems to exhonorate this code. So until I get more information I believe that was a false positive. Signed-off-by: Eric Biederman --- i8259.c | 12 ++++++++++++ 1 files changed, 12 insertions(+) diff -uNr linux-2.6.11-rc1-mm1-nokexec-x86_64-e820-64bit/arch/i386/kernel/i8259.c linux-2.6.11-rc1-mm1-nokexec-x86-i8259-shutdown/arch/i386/kernel/i8259.c --- linux-2.6.11-rc1-mm1-nokexec-x86_64-e820-64bit/arch/i386/kernel/i8259.c Fri Jan 14 04:32:22 2005 +++ linux-2.6.11-rc1-mm1-nokexec-x86-i8259-shutdown/arch/i386/kernel/i8259.c Tue Jan 18 22:44:27 2005 @@ -270,10 +270,22 @@ return 0; } +static int i8259A_shutdown(struct sys_device *dev) +{ + /* Put the i8259A into a quiescent state that + * the kernel initialization code can get it + * out of. + */ + outb(0xff, 0x21); /* mask all of 8259A-1 */ + outb(0xff, 0xA1); /* mask all of 8259A-1 */ + return 0; +} + static struct sysdev_class i8259_sysdev_class = { set_kset_name("i8259"), .suspend = i8259A_suspend, .resume = i8259A_resume, + .shutdown = i8259A_shutdown, }; static struct sys_device device_i8259A = { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/