Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261814AbVASScz (ORCPT ); Wed, 19 Jan 2005 13:32:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261812AbVASScy (ORCPT ); Wed, 19 Jan 2005 13:32:54 -0500 Received: from waste.org ([216.27.176.166]:60043 "EHLO waste.org") by vger.kernel.org with ESMTP id S261814AbVASScw (ORCPT ); Wed, 19 Jan 2005 13:32:52 -0500 Date: Wed, 19 Jan 2005 10:32:02 -0800 From: Matt Mackall To: "Jack O'Quin" Cc: Ingo Molnar , Chris Wright , Paul Davis , Christoph Hellwig , Andrew Morton , Lee Revell , arjanv@redhat.com, alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [request for inclusion] Realtime LSM Message-ID: <20050119183202.GM12076@waste.org> References: <871xcmuuu4.fsf@sulphur.joq.us> <20050116231307.GC24610@elte.hu> <87vf9xdj18.fsf@sulphur.joq.us> <20050117100633.GA3311@elte.hu> <87llaruy6m.fsf@sulphur.joq.us> <20050118080218.GB615@elte.hu> <87pt02pt0r.fsf@sulphur.joq.us> <20050119082433.GE29037@elte.hu> <20050119143927.GA11950@elte.hu> <87651tmhwv.fsf@sulphur.joq.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87651tmhwv.fsf@sulphur.joq.us> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 35 > > @@ -3211,6 +3211,12 @@ static inline task_t *find_process_by_pi > > static void __setscheduler(struct task_struct *p, int policy, int prio) > > { > > BUG_ON(p->array); > > + if (prio == 1 && policy != SCHED_NORMAL) { > > + p->policy = SCHED_NORMAL; > > + p->static_prio = NICE_TO_PRIO(-20); > > + p->prio = p->static_prio; > > + return; > > + } > > p->policy = policy; > > p->rt_priority = prio; > > if (policy != SCHED_NORMAL) > > > > JACK actually uses three different priorities, the defaults are 9, 10 > and 20. How about if I change this test? > > if (prio <= 20 && policy != SCHED_NORMAL) { > > Or, should that be? > > if (prio > 0 && prio <= 20 && policy != SCHED_NORMAL) { Or you can just drop the 'prio == 1 &&' part for this test. Ingo was trying to be clever to allow some RT bits, but that's not really necessary. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/