Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262133AbVATMNn (ORCPT ); Thu, 20 Jan 2005 07:13:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262134AbVATMNn (ORCPT ); Thu, 20 Jan 2005 07:13:43 -0500 Received: from webapps.arcom.com ([194.200.159.168]:13072 "EHLO webapps.arcom.com") by vger.kernel.org with ESMTP id S262133AbVATMNj (ORCPT ); Thu, 20 Jan 2005 07:13:39 -0500 Subject: [PATCH] smc91x: power down PHY on suspend From: Ian Campbell To: Nicolas Pitre Cc: akpm@osdl.org, Jeff Garzik , linux-kernel@vger.kernel.org Content-Type: text/plain Organization: Arcom Control Systems Date: Thu, 20 Jan 2005 12:13:37 +0000 Message-Id: <1106223217.19123.26.camel@icampbell-debian> Mime-Version: 1.0 X-Mailer: Evolution 2.0.3 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 20 Jan 2005 12:17:29.0906 (UTC) FILETIME=[02FB9120:01C4FEEA] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2712 Lines: 89 Hi, Powering down the PHY saves something like 100mA at 5V on my platform. Currently it is only done when the interface is brought down but it makes sense to do it on suspend as well. Signed-off-by: Ian Campbell Index: 2.6/drivers/net/smc91x.c =================================================================== --- 2.6.orig/drivers/net/smc91x.c 2005-01-17 11:04:43.000000000 +0000 +++ 2.6/drivers/net/smc91x.c 2005-01-20 12:11:09.292758475 +0000 @@ -1013,13 +1008,29 @@ /* * smc_phy_powerdown - powerdown phy * @dev: net device - * @phy: phy address * * Power down the specified PHY */ -static void smc_phy_powerdown(struct net_device *dev, int phy) +static void smc_phy_powerdown(struct net_device *dev) { + struct smc_local *lp = netdev_priv(dev); unsigned int bmcr; + int phy = lp->mii.phy_id; + + if (lp->phy_type == 0) + return; + + /* We need to ensure that no calls to smc_phy_configure are + pending. + + flush_scheduled_work() cannot be called because we are + running with the netlink semaphore held (from + devinet_ioctl()) and the pending work queue contains + linkwatch_event() (scheduled by netif_carrier_off() + above). linkwatch_event() also wants the netlink semaphore. + */ + while(lp->work_pending) + schedule(); bmcr = smc_phy_read(dev, phy, MII_BMCR); smc_phy_write(dev, phy, MII_BMCR, bmcr | BMCR_PDOWN); @@ -1544,21 +1555,7 @@ /* clear everything */ smc_shutdown(dev); - if (lp->phy_type != 0) { - /* We need to ensure that no calls to - smc_phy_configure are pending. - - flush_scheduled_work() cannot be called because we - are running with the netlink semaphore held (from - devinet_ioctl()) and the pending work queue - contains linkwatch_event() (scheduled by - netif_carrier_off() above). linkwatch_event() also - wants the netlink semaphore. - */ - while(lp->work_pending) - schedule(); - smc_phy_powerdown(dev, lp->mii.phy_id); - } + smc_phy_powerdown(dev); if (lp->pending_tx_skb) { dev_kfree_skb(lp->pending_tx_skb); @@ -2176,6 +2179,7 @@ if (netif_running(ndev)) { netif_device_detach(ndev); smc_shutdown(ndev); + smc_phy_powerdown(ndev); } } return 0; -- Ian Campbell, Senior Design Engineer Web: http://www.arcom.com Arcom, Clifton Road, Direct: +44 (0)1223 403 465 Cambridge CB1 7EA, United Kingdom Phone: +44 (0)1223 411 200 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/