Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262176AbVATPzG (ORCPT ); Thu, 20 Jan 2005 10:55:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262185AbVATPzF (ORCPT ); Thu, 20 Jan 2005 10:55:05 -0500 Received: from mailout.stusta.mhn.de ([141.84.69.5]:45586 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S262160AbVATPvA (ORCPT ); Thu, 20 Jan 2005 10:51:00 -0500 Date: Thu, 20 Jan 2005 16:50:54 +0100 From: Adrian Bunk To: "Eric W. Biederman" Cc: Andrew Morton , fastboot@lists.osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 19/29] x86_64-kexec Message-ID: <20050120155054.GD3170@stusta.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 29 On Wed, Jan 19, 2005 at 12:31:37AM -0700, Eric W. Biederman wrote: >... > --- linux-2.6.11-rc1-mm1-nokexec-x86_64-machine_shutdown/arch/x86_64/kernel/crash.c Wed Dec 31 17:00:00 1969 > +++ linux-2.6.11-rc1-mm1-nokexec-x86_64-kexec/arch/x86_64/kernel/crash.c Tue Jan 18 23:14:06 2005 >... > +note_buf_t crash_notes[NR_CPUS]; >... After your patches, this global variable stays completely unused on x86_64 (for the i386 version, you added a usage). cu Adrian BTW: Is external usage for crash_notes planned, or can it become static on both architectures? -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/