Date: Thu, 20 Jan 2005 16:03:42 -0800
From: Greg KH <greg@kroah.com>
To: Rogier Wolff <R.E.Wolff@harddisk-recovery.nl>
Cc: linux-kernel@vger.kernel.org, bryder@sgi.com, kuba@mareimbrium.org,
       ftdi-usb-sio-devel@lists.sourceforge.net, edwin@harddisk-recovery.nl
Subject: Re: Bug when using custom baud rates....
Message-ID: <20050121000342.GA14469@kroah.com>
References: <20050120145422.GB18037@bitwizard.nl> <20050120150857.GH13036@kroah.com> <20050120152256.GA3614@bitwizard.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050120152256.GA3614@bitwizard.nl>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1255
Lines: 44

On Thu, Jan 20, 2005 at 04:22:56PM +0100, Rogier Wolff wrote:
> On Thu, Jan 20, 2005 at 07:08:58AM -0800, Greg KH wrote:
> > On Thu, Jan 20, 2005 at 03:54:22PM +0100, Rogier Wolff wrote:
> > > Hi,
> > > 
> > > When using custom baud rates, the code does: 
> > > 
> > > 
> > >        if ((new_serial.baud_base != priv->baud_base) ||
> > >             (new_serial.baud_base < 9600))
> > >                 return -EINVAL;
> > > 
> > > Which translates to english as: 
> > > 
> > > 	If you changed the baud-base, OR the new one is
> > > 	invalid, return invalid. 
> > > 
> > > but it should be:
> > > 
> > > 	If you changed the baud-base, OR the new one is
> > > 	invalid, return invalid. 
> > 
> > You mean AND, not OR here, right?  :)
> 
> :-) Sorry. Too noisy here. 
> 
> > > Patch attached. 
> > 
> > Have a 2.6 patch?
> 
> Patch told me: 
>    patching file drivers/usb/serial/ftdi_sio.c
>    Hunk #1 succeeded at 1137 (offset 156 lines).
> 
> but the resulting patch is attached. 

Applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/