Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262272AbVAUF7o (ORCPT ); Fri, 21 Jan 2005 00:59:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262262AbVAUF7n (ORCPT ); Fri, 21 Jan 2005 00:59:43 -0500 Received: from fw.osdl.org ([65.172.181.6]:31371 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262281AbVAUFvS (ORCPT ); Fri, 21 Jan 2005 00:51:18 -0500 Date: Thu, 20 Jan 2005 21:51:03 -0800 From: Chris Wright To: Andi Kleen Cc: Chris Wright , "Michael S. Tsirkin" , Andrew Morton , Greg KH , tiwai@suse.de, mingo@elte.hu, rlrevell@joe-job.com, linux-kernel@vger.kernel.org, pavel@suse.cz, discuss@x86-64.org, gordon.jin@intel.com, alsa-devel@lists.sourceforge.net, VANDROVE@vc.cvut.cz Subject: Re: [PATCH] compat ioctl security hook fixup Message-ID: <20050120215103.S24171@build.pdx.osdl.net> References: <20050106140636.GE25629@mellanox.co.il> <20050112203606.GA23307@mellanox.co.il> <20050112212954.GA13558@kroah.com> <20050112214326.GB14703@wotan.suse.de> <20050112225230.GA14590@kroah.com> <20050112151049.7473db7d.akpm@osdl.org> <20050119213818.55b14bb0.akpm@osdl.org> <20050121000935.GA341@mellanox.co.il> <20050120172656.R24171@build.pdx.osdl.net> <20050121041959.GA27155@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20050121041959.GA27155@wotan.suse.de>; from ak@suse.de on Fri, Jan 21, 2005 at 05:19:59AM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 19 * Andi Kleen (ak@suse.de) wrote: > I'm not sure really adding vfs_ioctl is a good idea politically. > I predict we'll see drivers starting to use it, which will cause quite > broken design. Yes, that'd be quite broken. I didn't have the same expectation. > If you add it make at least sure it's not EXPORT_SYMBOL()ed. It's certainly not, nor intended to be. Would a comment to that affect alleviate your concern? thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/