Date: Fri, 21 Jan 2005 14:06:30 -0800
From: Greg KH <greg@kroah.com>
To: "Williams, Mitch A" <mitch.a.williams@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysfs write fixes
Message-ID: <20050121220630.GA3231@kroah.com>
References: <F3EE2A9EB4576F40AFE238EC0AC04BC50488BA12@orsmsx402.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F3EE2A9EB4576F40AFE238EC0AC04BC50488BA12@orsmsx402.amr.corp.intel.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1320
Lines: 40

On Fri, Jan 21, 2005 at 01:44:45PM -0800, Williams, Mitch A wrote:
> This patch corrects some errors that we saw while writing to sysfs
> files.
>  - Attempts to open the file in append mode result in error
>  - Writes are buffered and flushed to the kobject owner during close
>  - Attempts to seek on sysfs files result in error
> 
> Generated from 2.6.11-rc1.
> 
> It's not a big patch, but if you'd like it whacked up into smaller ones,
> I'll
> be glad to do so.

Please split it up into different patches in different emails.  Also,
fix your email client, the patch was line wrapped.

And don't add this:

> @@ -1,5 +1,11 @@
>  /*
>   * file.c - operations for regular (text) files.
> + *
> + * Changes:
> + * 2004/01/21 Mitch Williams <mitch.a.williams at intel.com>
> + *   - Changed llseek method to be no_llseek.
> + *   - Opening a file for append now returns an error.
> + *   - Writes are now buffered and flushed at close
>   */

Changes show up in the change log comments, not within the files.
Otherwise, over time they grow out of control.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/