Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262419AbVAVBy5 (ORCPT ); Fri, 21 Jan 2005 20:54:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262421AbVAVBy5 (ORCPT ); Fri, 21 Jan 2005 20:54:57 -0500 Received: from omx3-ext.sgi.com ([192.48.171.20]:59108 "EHLO omx3.sgi.com") by vger.kernel.org with ESMTP id S262419AbVAVByw (ORCPT ); Fri, 21 Jan 2005 20:54:52 -0500 Date: Fri, 21 Jan 2005 17:54:26 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Paul Mackerras cc: Andrew Morton , davem@davemloft.net, hugh@veritas.com, linux-ia64@vger.kernel.org, torvalds@osdl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: Extend clear_page by an order parameter In-Reply-To: <16881.43936.632734.780383@cargo.ozlabs.ibm.com> Message-ID: References: <20050108135636.6796419a.davem@davemloft.net> <16881.33367.660452.55933@cargo.ozlabs.ibm.com> <16881.40893.35593.458777@cargo.ozlabs.ibm.com> <20050121164353.6f205fbc.akpm@osdl.org> <16881.43936.632734.780383@cargo.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1300 Lines: 25 On Sat, 22 Jan 2005, Paul Mackerras wrote: > Christoph's patch is bigger than it needs to be because he has to > change all the occurrences of clear_page(x) to clear_page(x, 0), and > then he has to change a lot of architectures' clear_page functions to > be called _clear_page instead. If he picked a different name for the > "clear a higher order page" function it would end up being less > invasive as well as less confusing. I had the name "zero_page" in V1 and V2 of the patch where it was separate. Then someone complained about code duplication. > The argument that clear_page is called that because it clears a higher > order page won't wash; all the clear_page implementations in his patch > are perfectly capable of clearing any contiguous set of 2^order pages > (oops, I mean "zero-order pages"), not just a "higher order page". clear_page is called clear_page because it clears one page of *any* order not just higher orders. zero-order pages are not segregated nor are they intrisincally better just because they contain more memory ;-). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/