Date: Sun, 23 Jan 2005 13:05:14 -0800
From: Andrew Morton <akpm@osdl.org>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] core-small: Introduce CONFIG_CORE_SMALL from -tiny
Message-Id: <20050123130514.0a9656bb.akpm@osdl.org>
In-Reply-To: <20050123175204.GV12076@waste.org>
References: <1.464233479@selenic.com>
	<20050123004042.09f7f8eb.akpm@osdl.org>
	<20050123175204.GV12076@waste.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1087
Lines: 35

Matt Mackall <mpm@selenic.com> wrote:
>
> > I wish it didn't have "core" in the name.  A little misleading.
> 
>  Well I've got another set called NET_SMALL. BASE?

BASE works, I guess.

>  > #define PID_MAX_DEFAULT (CONFIG_CORE_SMALL ? 0x1000 : 0x8000)
>  > #define UIDHASH_BITS (CONFIG_CORE_SMALL ? 3 : 8)
>  > #define FUTEX_HASHBITS (CONFIG_CORE_SMALL ? 4 : 8)
>  > etc.
> 
>  Hmm. I think we'd want a hidden config variable for this and I'm not
>  sure how well the config language allows setting an int from a bool.

config AKPM_BOOL
        bool "akpm"

config AKPM_INT
        int
        default 1 if AKPM_BOOL
        default 0 if !AKPM_BOOL

seems to do everything which it should.

>  And then it would need another name. On the whole, seems more complex
>  than what I've done.

No, it's quite simple and avoids lots of ifdeffing.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/