Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261385AbVAXAWy (ORCPT ); Sun, 23 Jan 2005 19:22:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261388AbVAXAWy (ORCPT ); Sun, 23 Jan 2005 19:22:54 -0500 Received: from omx2-ext.sgi.com ([192.48.171.19]:27108 "EHLO omx2.sgi.com") by vger.kernel.org with ESMTP id S261385AbVAXAWx (ORCPT ); Sun, 23 Jan 2005 19:22:53 -0500 Date: Mon, 24 Jan 2005 11:21:29 +1100 From: Nathan Scott To: Matt Mackall , Andreas Gruenbacher Cc: Andi Kleen , Felipe Alfaro Solana , Trond Myklebust , linux-kernel@vger.kernel.org, Buck Huppmann , Neil Brown , "Andries E. Brouwer" , Andrew Morton , Olaf Kirch Subject: Re: [patch 1/13] Qsort Message-ID: <20050124112129.C1545508@wobbly.melbourne.sgi.com> References: <20050122203326.402087000@blunzn.suse.de> <20050122203618.962749000@blunzn.suse.de> <20050123042930.GI3867@waste.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20050123042930.GI3867@waste.org>; from mpm@selenic.com on Sat, Jan 22, 2005 at 08:29:30PM -0800 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 22 On Sat, Jan 22, 2005 at 08:29:30PM -0800, Matt Mackall wrote: > On Sun, Jan 23, 2005 at 03:39:34AM +0100, Andi Kleen wrote: > > c) the three-way median selection does help avoid worst-case O(n^2) > behavior, which might potentially be triggerable by users in places > like XFS where this is used XFS's needs are simple - we're just sorting dirents within a single directory block or smaller, and sorting EA lists/ACLs - all of which are small arrays, so a qsort optimised for small arrays suits XFS well. Take care not to put any arrays on the stack though, else the CONFIG_4KSTACKS punters won't be happy. cheers. -- Nathan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/