Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261584AbVAXTYg (ORCPT ); Mon, 24 Jan 2005 14:24:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261580AbVAXTYg (ORCPT ); Mon, 24 Jan 2005 14:24:36 -0500 Received: from s2.home.ro ([193.231.236.41]:54252 "EHLO s2.home.ro") by vger.kernel.org with ESMTP id S261584AbVAXTVg (ORCPT ); Mon, 24 Jan 2005 14:21:36 -0500 Subject: Re: kernel oops! From: ierdnah To: Linus Torvalds Cc: Alan Cox , Kernel Mailing List In-Reply-To: References: <1106437010.32072.0.camel@ierdnac> <1106483340.21951.4.camel@ierdnac> Content-Type: text/plain Date: Mon, 24 Jan 2005 21:21:34 +0200 Message-Id: <1106594494.31049.5.camel@ierdnac> Mime-Version: 1.0 X-Mailer: Evolution 2.0.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 37 On Sun, 2005-01-23 at 09:51 -0800, Linus Torvalds wrote: I applied the patch and the uptime is 1 day and no oops, i will wait 2 more days too see if the oops appears, then I will compile the kernel with CONFIG_PREEMPT. Before, when PREEMPT was enabled, the oops appeared immediatly after booting and more often. > ---- > --- 1.32/drivers/char/pty.c 2005-01-10 17:29:36 -08:00 > +++ edited/drivers/char/pty.c 2005-01-23 09:49:16 -08:00 > @@ -149,13 +149,15 @@ > static int pty_chars_in_buffer(struct tty_struct *tty) > { > struct tty_struct *to = tty->link; > + ssize_t (*chars_in_buffer)(struct tty_struct *); > int count; > > - if (!to || !to->ldisc.chars_in_buffer) > + /* We should get the line discipline lock for "tty->link" */ > + if (!to || !(chars_in_buffer = to->ldisc.chars_in_buffer)) > return 0; > > /* The ldisc must report 0 if no characters available to be read */ > - count = to->ldisc.chars_in_buffer(to); > + count = chars_in_buffer(to); > > if (tty->driver->subtype == PTY_TYPE_SLAVE) return count; > > -- ierdnah - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/