Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261704AbVAXWhn (ORCPT ); Mon, 24 Jan 2005 17:37:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261705AbVAXWhC (ORCPT ); Mon, 24 Jan 2005 17:37:02 -0500 Received: from fw.osdl.org ([65.172.181.6]:14054 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261704AbVAXWgA (ORCPT ); Mon, 24 Jan 2005 17:36:00 -0500 Date: Mon, 24 Jan 2005 14:35:47 -0800 (PST) From: Linus Torvalds To: Andrew Morton cc: Jens Axboe , alexn@dsv.su.se, kas@fi.muni.cz, linux-kernel@vger.kernel.org, lennert.vanalboom@ugent.be Subject: Re: Memory leak in 2.6.11-rc1? In-Reply-To: <20050124125649.35f3dafd.akpm@osdl.org> Message-ID: References: <20050121161959.GO3922@fi.muni.cz> <1106360639.15804.1.camel@boxen> <20050123091154.GC16648@suse.de> <20050123011918.295db8e8.akpm@osdl.org> <20050123095608.GD16648@suse.de> <20050123023248.263daca9.akpm@osdl.org> <1106528219.867.22.camel@boxen> <20050124204659.GB19242@suse.de> <20050124125649.35f3dafd.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 34 On Mon, 24 Jan 2005, Andrew Morton wrote: > > Would indicate that the new pipe code is leaking. Duh. It's the pipe merging. Linus ---- --- 1.40/fs/pipe.c 2005-01-15 12:01:16 -08:00 +++ edited/fs/pipe.c 2005-01-24 14:35:09 -08:00 @@ -630,13 +630,13 @@ struct pipe_inode_info *info = inode->i_pipe; inode->i_pipe = NULL; - if (info->tmp_page) - __free_page(info->tmp_page); for (i = 0; i < PIPE_BUFFERS; i++) { struct pipe_buffer *buf = info->bufs + i; if (buf->ops) buf->ops->release(info, buf); } + if (info->tmp_page) + __free_page(info->tmp_page); kfree(info); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/