Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261825AbVAYF5E (ORCPT ); Tue, 25 Jan 2005 00:57:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261826AbVAYF5E (ORCPT ); Tue, 25 Jan 2005 00:57:04 -0500 Received: from mail.kroah.org ([69.55.234.183]:44507 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261825AbVAYF5B (ORCPT ); Tue, 25 Jan 2005 00:57:01 -0500 Date: Mon, 24 Jan 2005 21:56:51 -0800 From: Greg KH To: Jirka Kosina Cc: Patrick Mochel , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix bad locking in drivers/base/driver.c Message-ID: <20050125055651.GA1987@kroah.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 23 On Mon, Jan 24, 2005 at 07:25:19PM +0100, Jirka Kosina wrote: > Hi, > > there has been (for quite some time) a bug in function driver_unregister() > - the lock/unlock sequence is protecting nothing and the actual > bus_remove_driver() is called outside critical section. > > Please apply. No, please read the comment in the code about why this is the way it is. The code is correct as is. Also, please CC the driver core maintainer next time for patches like this so I don't miss them when they go by. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/