Subject: Re: RFC: use datacs is smc91x driver
From: Ian Campbell <icampbell@arcom.com>
To: Nicolas Pitre <nico@cam.org>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <Pine.LNX.4.61.0501241459090.7307@localhost.localdomain>
References: <1106569302.19123.49.camel@icampbell-debian>
	 <Pine.LNX.4.61.0501241459090.7307@localhost.localdomain>
Content-Type: text/plain
Organization: Arcom Control Systems
Date: Tue, 25 Jan 2005 11:14:16 +0000
Message-Id: <1106651657.19123.54.camel@icampbell-debian>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1675
Lines: 33

On Mon, 2005-01-24 at 15:20 -0500, Nicolas Pitre wrote:
> On Mon, 24 Jan 2005, Ian Campbell wrote:
> > I'm not entirely happy with using the SMC_*_RESOURCE defines to find the
> > correct resources, but I don't think you can have a placeholder for the
> > attrib space at index 1 (when you don't have an attrib space) and still
> > have datacs at index 2.
> 
> I don't like that either.  Maybe the whole thing should be converted to 
> use platform_get_resource_byname() ?

Ah, I hadn't seen this new function, it looks ideal. I'll work up
another that uses it and updates all the in tree drivers. 

Are you happy with "iocs", "attrib" and "datacs" for the names?

Ian.

-- 
Ian Campbell, Senior Design Engineer
                                        Web: http://www.arcom.com
Arcom, Clifton Road,                    Direct: +44 (0)1223 403 465
Cambridge CB1 7EA, United Kingdom       Phone:  +44 (0)1223 411 200


_____________________________________________________________________
The message in this transmission is sent in confidence for the attention of the addressee only and should not be disclosed to any other party. Unauthorised recipients are requested to preserve this confidentiality. Please advise the sender if the addressee is not resident at the receiving end.  Email to and from Arcom is automatically monitored for operational and lawful business reasons.

This message has been virus scanned by MessageLabs.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/