Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261933AbVAYNXt (ORCPT ); Tue, 25 Jan 2005 08:23:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261934AbVAYNXt (ORCPT ); Tue, 25 Jan 2005 08:23:49 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:29356 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S261933AbVAYNXs (ORCPT ); Tue, 25 Jan 2005 08:23:48 -0500 Date: Tue, 25 Jan 2005 07:35:02 -0200 From: Marcelo Tosatti To: Vasily Averin Cc: Marcelo Tosatti , Andrey Melnikov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Prevent NMI oopser Message-ID: <20050125093502.GA19585@logos.cnet> References: <41F5F98C.7020004@sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41F5F98C.7020004@sw.ru> User-Agent: Mutt/1.5.5.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 20 On Tue, Jan 25, 2005 at 10:47:24AM +0300, Vasily Averin wrote: > Marcello, Andrey > > I believe this patch is wrong. > First, it prevent nothing: NMI watchdog is a signal that you wait too > long with disabled interrupts. Your controller was not answered too > long, obviously it is a hardware issue. > Second, you could not call schedule() with io_request_lock spinlock taken. > > You should unlock io_request_lock before msleep, like in latest versions > of megaraid2 drivers. > > Please fix it. OK, I've reverted it for now - waiting for megaraid2 update from LSI crew. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/