Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262078AbVAYTUV (ORCPT ); Tue, 25 Jan 2005 14:20:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262077AbVAYTUV (ORCPT ); Tue, 25 Jan 2005 14:20:21 -0500 Received: from mail.kroah.org ([69.55.234.183]:6371 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261660AbVAYTUG (ORCPT ); Tue, 25 Jan 2005 14:20:06 -0500 Date: Tue, 25 Jan 2005 11:19:50 -0800 From: Greg KH To: Linus Torvalds Cc: Mike Waychison , Bill Davidsen , Jirka Kosina , Patrick Mochel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix bad locking in drivers/base/driver.c Message-ID: <20050125191950.GA11445@kroah.com> References: <20050125055651.GA1987@kroah.com> <41F5F623.5090903@sun.com> <41F64E87.8040501@tmr.com> <41F66F86.4000609@sun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 30 On Tue, Jan 25, 2005 at 08:27:15AM -0800, Linus Torvalds wrote: > > > Hmm.. I certainly like the "use completions" patch, since it makes it a > lot more obvious what is going on (and it is what completions were > designed for). > > However, since it does change semantics very subtly: if you call > "driver_unregister()" twice (which is wrong, but looking at the code it > looks like it would just silently have worked), the old code would just > ignore it. The new code will block on the second one. > > Now, I don't mind the blocking (it's a bug to call it twice, and blocking > should even give a nice callback when you do the "show tasks" sysrq, so > it's a good way to _find_ the bug), but together with Mike's comment about > "Compile-tested only", I'd really like somebody (Greg?) to say "trying to > doubly remove the driver is so illegal that we don't care, and btw, I > tested it and it's all ok". I will add it to my queue of patches for the driver core, and test it out accordingly before trying it out in the -mm tree for a while. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/