Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262131AbVAYVXn (ORCPT ); Tue, 25 Jan 2005 16:23:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262148AbVAYVUC (ORCPT ); Tue, 25 Jan 2005 16:20:02 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:33664 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S262131AbVAYVR3 (ORCPT ); Tue, 25 Jan 2005 16:17:29 -0500 Date: Tue, 25 Jan 2005 21:17:24 +0000 From: Al Viro To: John Richard Moser Cc: Linus Torvalds , Bill Davidsen , Valdis.Kletnieks@vt.edu, Arjan van de Ven , Ingo Molnar , Christoph Hellwig , Dave Jones , Andrew Morton , marcelo.tosatti@cyclades.com, Greg KH , chrisw@osdl.org, Alan Cox , Kernel Mailing List Subject: Re: thoughts on kernel security issues Message-ID: <20050125211723.GE8859@parcelfarce.linux.theplanet.co.uk> References: <1106157152.6310.171.camel@laptopd505.fenrus.org> <200501191947.j0JJlf3j024206@turing-police.cc.vt.edu> <41F6604B.4090905@tmr.com> <41F6816D.1020306@tmr.com> <41F68975.8010405@comcast.net> <41F691D6.8040803@comcast.net> <41F6A5F8.5030100@comcast.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41F6A5F8.5030100@comcast.net> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 26 On Tue, Jan 25, 2005 at 03:03:04PM -0500, John Richard Moser wrote: > > and combining them has _zero_ advantages (whatever bug the combined patch > > fix _will_ be fixed by the series of individual patches too - even if the > > splitting was buggy in some respect, you are pretty much guaranteed of > > this, since the bug you were trying to fix is the _one_ thing you are > > really testing for). > > Lots of work to split up a patch though. Exactly. And since that's a prerequisite for any meaningful review, some equivalent of that work will have to be done at some point. The only question is who will be doing that work - proponents of patch or reviewers? Look at it that way: when you are submitting a paper for publication, it's your responsibility to get it into form that would allow review. Sending a lump of something that might, given considerable efforts, be massaged into readable and understandable text is not going to fly. And doing that with "it's a lot of work [so could reviewers please do that work themselves and spare me the efforts]" as rationale... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/