Return-Path: <linux-kernel-owner+willy=40w.ods.org-S262160AbVAYVom@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S262160AbVAYVom (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 25 Jan 2005 16:44:42 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262132AbVAYVol
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 25 Jan 2005 16:44:41 -0500
Received: from fsmlabs.com ([168.103.115.128]:43689 "EHLO fsmlabs.com")
	by vger.kernel.org with ESMTP id S262160AbVAYVlx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Jan 2005 16:41:53 -0500
Date: Tue, 25 Jan 2005 14:42:13 -0700 (MST)
From: Zwane Mwaikambo <zwane@arm.linux.org.uk>
To: Matt Mackall <mpm@selenic.com>
cc: Andrew Morton <akpm@osdl.org>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.11-rc2-mm1 Random related problems
In-Reply-To: <20050125204056.GL12076@waste.org>
Message-ID: <Pine.LNX.4.61.0501251442020.7989@montezuma.fsmlabs.com>
References: <Pine.LNX.4.61.0501242134390.3010@montezuma.fsmlabs.com>
 <20050125204056.GL12076@waste.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1598
Lines: 36

On Tue, 25 Jan 2005, Matt Mackall wrote:

> On Mon, Jan 24, 2005 at 09:36:37PM -0700, Zwane Mwaikambo wrote:
> > I'm having trouble booting here, were those random-* patches tested?
> > 
> > EIP is at __add_entropy_words+0xc5/0x1c0
> > eax: 0000002d   ebx: 0000000f   ecx: 0000007b   edx: f5e50000
> > esi: c0810980   edi: 0000000f   ebp: f5e4fea4   esp: f5e4fe5c
> > ds: 007b   es: 007b   ss: 0068
> > Process dd (pid: 2255, threadinfo=f5e4e000 task=ebdd7ac0)
> > Stack: 00000010 78000000 c07043e0 00000286 0000007b 0000001f 00000001 00000007
> >        0000000e 00000014 0000001a 00000000 0000002d f5e50000 c07043c0 00000080
> >        c0704340 c07043c0 f5e4ff40 c037a4e0 00000000 00000010 2cda69d0 f7b9f75e
> > Call Trace:
> >  [<c010403a>] show_stack+0x7a/0x90
> >  [<c01041c6>] show_registers+0x156/0x1c0
> >  [<c01043e0>] die+0x100/0x190
> >  [<c0116d59>] do_page_fault+0x349/0x63f
> >  [<c0103cc7>] error_code+0x2b/0x30
> >  [<c037a4e0>] xfer_secondary_pool+0xb0/0xe0
> 
> This oops is add_entropy_words running off the top of the stack
> reading its input. The overrun is harmless until it causes a page
> fault. After much staring:
> 
> This should fix Zwane's oops. Looks like I introduced this bug in Aug
> 2003, but it was hard to trigger until the recent changes. But it
> ought to make it to mainline soonish.

Thanks Matt, that fixes it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/