Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1455675yba; Sun, 21 Apr 2019 07:22:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqz4ljhszEmPpeIVX43L0Ck9iYswLatg03vhnFf+9RLP7x/LiAdVOBadYTBwhNEm6WR8B/nL X-Received: by 2002:a62:61c2:: with SMTP id v185mr15254255pfb.117.1555856528824; Sun, 21 Apr 2019 07:22:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555856528; cv=none; d=google.com; s=arc-20160816; b=IkihgsspyD019UJ1nAhnfr/zIKKnCuV73iy6e193/8drBQO1J2JmLSIW5EiEE4ZTw8 i3er6LYJGelHD/TZ9pSfj2j2/vICw+qyM2oA+Qu5CzF4M3sht2SLON48KrEDHGMHE2BR s2h8wzbMcT/vCRgf0OMxfqDTCHn6C1VElNsi1y/Cjd1S61tOkYHUmZnaX2WV3MxuRf6v rJJFzkRoNWV1aKKhKZGFNegpKKTXRF+DiQmtX+KsdQItErvDKljix/mLcGwVxhknf3ql eHrIhjOrntp4wBM600cdAyL278cwiMbomzmwi6+99kPbtfKyIQ3GmYLNKBTKv80XMlsE cavg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=HczryLAF4CiKCczua4jrioIan4esZymWs4aU5HUl+qo=; b=tgibfdM//P/iN6yq5d+4o6OREL3JSunYsz3awWQZEV3pRw6NoetCRsmvTBhvicvCdD 1HdBN8Q8XCYZ8jTtt63c0nTnt1Xbvb2Rp0MkZOe9xpDKrwsXbd7c7d+Th9ctjWvZXEcZ 8YGQo6AU+rokwwRbTbJHIM+MNqja+7L8Jvu/9ielNBH5OEnTvEDaGx8Wq/1rc/ZlPP0M VCaIE/vqdJFHSB/q36ZefatGBJyzQzytsKT9RALeuY7n0U2UUxJCG8vMBxQE0xNJ+zga wwmO4F8jPiNMHbnAy090osg50C5+yyKmQYPpOD5He9T5OnqnUaAXeB1+52eVbgdwswJe mxMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i26si10956438pfd.140.2019.04.21.07.21.53; Sun, 21 Apr 2019 07:22:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727495AbfDUOSo (ORCPT + 99 others); Sun, 21 Apr 2019 10:18:44 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:41657 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbfDUOSn (ORCPT ); Sun, 21 Apr 2019 10:18:43 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 44nBdt1tHHz9s8m; Mon, 22 Apr 2019 00:18:42 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 6c84f8c5cbfb4bf728f88296bc035c4a401c3423 X-Patchwork-Hint: ignore In-Reply-To: <0365f99ce2b9273e269a241394957cba924f995e.1551951985.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: powerpc/highmem: change BUG_ON() to WARN_ON() Message-Id: <44nBdt1tHHz9s8m@ozlabs.org> Date: Mon, 22 Apr 2019 00:18:42 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-03-07 at 09:47:50 UTC, Christophe Leroy wrote: > In arch/powerpc/mm/highmem.c, BUG_ON() is called only when > CONFIG_DEBUG_HIGHMEM is selected, this means the BUG_ON() is > not vital and can be replaced by a a WARN_ON > > At the sametime, use IS_ENABLED() instead of #ifdef to clean a bit. > > Signed-off-by: Christophe Leroy Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/6c84f8c5cbfb4bf728f88296bc035c4a cheers