Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Ming Lei <ming.lei@redhat.com>, Greg Edwards <gedwards@ddn.com>,
        Hannes Reinecke <hare@suse.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jens Axboe <axboe@kernel.dk>,
        Bart Van Assche <bvanassche@acm.org>,
        Omar Sandoval <osandov@fb.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [RFC PATCH 2/2] null_blk: Make use of size_to_sectors helper
Thread-Topic: [RFC PATCH 2/2] null_blk: Make use of size_to_sectors helper
Thread-Index: AQHU9/Xh1+QytUG6QUKoMOUHE1nFqQ==
Date:   Sun, 21 Apr 2019 17:42:27 +0000
Message-ID: <SN6PR04MB4527DAFECD39E2C26DDF4CE586210@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <20190421035328.19322-1-marcos.souza.org@gmail.com>
 <20190421035328.19322-3-marcos.souza.org@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d52cc22-6c0e-4ab3-971f-08d6c680b8ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2019 17:42:27.9365
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4462
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good.=0A=
=0A=
Reviewed-by : Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
On 04/20/2019 08:54 PM, Marcos Paulo de Souza wrote:=0A=
> This helper tries to make the code easier to read, and unifies the code=
=0A=
> of returning the number of sectors for a given number of bytes.=0A=
>=0A=
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>=0A=
> ---=0A=
>   drivers/block/null_blk_main.c | 18 +++++++++---------=0A=
>   1 file changed, 9 insertions(+), 9 deletions(-)=0A=
>=0A=
> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.=
c=0A=
> index d7ac09c092f2..05f0bef54296 100644=0A=
> --- a/drivers/block/null_blk_main.c=0A=
> +++ b/drivers/block/null_blk_main.c=0A=
> @@ -853,7 +853,7 @@ static int null_flush_cache_page(struct nullb *nullb,=
 struct nullb_page *c_page)=0A=
>   	dst =3D kmap_atomic(t_page->page);=0A=
>=0A=
>   	for (i =3D 0; i < PAGE_SECTORS;=0A=
> -			i +=3D (nullb->dev->blocksize >> SECTOR_SHIFT)) {=0A=
> +			i +=3D (size_to_sectors(nullb->dev->blocksize))) {=0A=
>   		if (test_bit(i, c_page->bitmap)) {=0A=
>   			offset =3D (i << SECTOR_SHIFT);=0A=
>   			memcpy(dst + offset, src + offset,=0A=
> @@ -957,7 +957,7 @@ static int copy_to_nullb(struct nullb *nullb, struct =
page *source,=0A=
>   			null_free_sector(nullb, sector, true);=0A=
>=0A=
>   		count +=3D temp;=0A=
> -		sector +=3D temp >> SECTOR_SHIFT;=0A=
> +		sector +=3D size_to_sectors(temp);=0A=
>   	}=0A=
>   	return 0;=0A=
>   }=0A=
> @@ -989,7 +989,7 @@ static int copy_from_nullb(struct nullb *nullb, struc=
t page *dest,=0A=
>   		kunmap_atomic(dst);=0A=
>=0A=
>   		count +=3D temp;=0A=
> -		sector +=3D temp >> SECTOR_SHIFT;=0A=
> +		sector +=3D size_to_sectors(temp);=0A=
>   	}=0A=
>   	return 0;=0A=
>   }=0A=
> @@ -1004,7 +1004,7 @@ static void null_handle_discard(struct nullb *nullb=
, sector_t sector, size_t n)=0A=
>   		null_free_sector(nullb, sector, false);=0A=
>   		if (null_cache_active(nullb))=0A=
>   			null_free_sector(nullb, sector, true);=0A=
> -		sector +=3D temp >> SECTOR_SHIFT;=0A=
> +		sector +=3D size_to_sectors(temp);=0A=
>   		n -=3D temp;=0A=
>   	}=0A=
>   	spin_unlock_irq(&nullb->lock);=0A=
> @@ -1074,7 +1074,7 @@ static int null_handle_rq(struct nullb_cmd *cmd)=0A=
>   			spin_unlock_irq(&nullb->lock);=0A=
>   			return err;=0A=
>   		}=0A=
> -		sector +=3D len >> SECTOR_SHIFT;=0A=
> +		sector +=3D size_to_sectors(len);=0A=
>   	}=0A=
>   	spin_unlock_irq(&nullb->lock);=0A=
>=0A=
> @@ -1109,7 +1109,7 @@ static int null_handle_bio(struct nullb_cmd *cmd)=
=0A=
>   			spin_unlock_irq(&nullb->lock);=0A=
>   			return err;=0A=
>   		}=0A=
> -		sector +=3D len >> SECTOR_SHIFT;=0A=
> +		sector +=3D size_to_sectors(len);=0A=
>   	}=0A=
>   	spin_unlock_irq(&nullb->lock);=0A=
>   	return 0;=0A=
> @@ -1201,7 +1201,7 @@ static blk_status_t null_handle_cmd(struct nullb_cm=
d *cmd)=0A=
>   		if (dev->queue_mode =3D=3D NULL_Q_BIO) {=0A=
>   			op =3D bio_op(cmd->bio);=0A=
>   			sector =3D cmd->bio->bi_iter.bi_sector;=0A=
> -			nr_sectors =3D cmd->bio->bi_iter.bi_size >> 9;=0A=
> +			nr_sectors =3D size_to_sectors(cmd->bio->bi_iter.bi_size);=0A=
>   		} else {=0A=
>   			op =3D req_op(cmd->rq);=0A=
>   			sector =3D blk_rq_pos(cmd->rq);=0A=
> @@ -1406,7 +1406,7 @@ static void null_config_discard(struct nullb *nullb=
)=0A=
>   		return;=0A=
>   	nullb->q->limits.discard_granularity =3D nullb->dev->blocksize;=0A=
>   	nullb->q->limits.discard_alignment =3D nullb->dev->blocksize;=0A=
> -	blk_queue_max_discard_sectors(nullb->q, UINT_MAX >> 9);=0A=
> +	blk_queue_max_discard_sectors(nullb->q, size_to_sectors(UINT_MAX));=0A=
>   	blk_queue_flag_set(QUEUE_FLAG_DISCARD, nullb->q);=0A=
>   }=0A=
>=0A=
> @@ -1520,7 +1520,7 @@ static int null_gendisk_register(struct nullb *null=
b)=0A=
>   	if (!disk)=0A=
>   		return -ENOMEM;=0A=
>   	size =3D (sector_t)nullb->dev->size * 1024 * 1024ULL;=0A=
> -	set_capacity(disk, size >> 9);=0A=
> +	set_capacity(disk, size_to_sectors(size));=0A=
>=0A=
>   	disk->flags |=3D GENHD_FL_EXT_DEVT | GENHD_FL_SUPPRESS_PARTITION_INFO;=
=0A=
>   	disk->major		=3D null_major;=0A=
>=0A=
=0A=