Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2035465yba; Sun, 21 Apr 2019 22:09:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTvCuylYXSPM4elUNSlqJGsPLVW3+hCQma7E3MtQIfG+BN6lYn6FA2eRlcl5NJMhjGQ5xb X-Received: by 2002:a62:14d7:: with SMTP id 206mr18396610pfu.162.1555909774470; Sun, 21 Apr 2019 22:09:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555909774; cv=none; d=google.com; s=arc-20160816; b=RrDoZ0He/A0wA/KGlNJo92B8DIFz2E5QZIDRUjWO6EG/+1Cnqj9GmuNq8XPCraki/w pv4/brWWM1kq4lV28WI6ynnfiFlenpXQv1QLRPcIymKX+YCVZ/6q3FVPXwu7YPINl2MU tLAKQcA+hf+V0Old/Wnyp2sMW6TiNx8AmRxinU1V1tp4DNGv+lykZCV6QbEzPJB0uw8e /GtnV8E8jIZNL0KbI/cQEMjy3hXT1lu3TDjV2XgilvjNP8l4jSeGTBsgHTCZiY0wB4hj YO490nrihDVXkSk4o/GVVOUSeM+yS/tXqLm5waAmdueZgUMTVcRh7g/5cemkRXCWOj2U 8bQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nsMmiC7jhSKTFlhgcEpu4yxQzWbtu7ogv5Doohyfyhc=; b=LlkJdhuLkF9z2+g+CSUVWNBJnwM/FNMT55c/6BgdI4w1xsC9+q/6Q3kqbmKoKRWnL4 Ko3UHVIDwx9rMAJC5fJovnjngUWL2R3/wVanoA3DrLeuxMVkMpVm/HMKHCYVlB73+0Cq C49I66xXDHSBKk9VSV9mfiiAjil9/Vhxrn47UCBnsJsQBCKzNyFofpWAU1DrVKmFLodv qWZo10KHw3YcVe1bx9pRgJAKFkK/phSe1zznn9hy8x10/OQfJxfZvr6HVipm0wiFNpoj 3oTc2NRByQW8FFUVRqfGcOXMLHVb/d07bkAgWnaIWTNNS+zwTcA4OI17TM4TUPJ7T5DO 09eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=O897wwR5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y29si11899176pgk.120.2019.04.21.22.09.08; Sun, 21 Apr 2019 22:09:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=O897wwR5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfDVFEW (ORCPT + 99 others); Mon, 22 Apr 2019 01:04:22 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46176 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbfDVFEW (ORCPT ); Mon, 22 Apr 2019 01:04:22 -0400 Received: by mail-pf1-f195.google.com with SMTP id 9so5123513pfj.13; Sun, 21 Apr 2019 22:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nsMmiC7jhSKTFlhgcEpu4yxQzWbtu7ogv5Doohyfyhc=; b=O897wwR5sSHdszjTGLUArhG7+M6XZAfs4T3tCp2tl2beeeoNSwHcLtcIAcgpC9kJ4B eAOkpvGWAR+N7H3OpCh5eP3ANc5jwVI0VJPC04qBJK9PgI7x/PlsLgmIek1O4nO6JT/Y 1Ju0H5EQYsMC4XH89En3loHtiqrTR2UuoUi8GjLpUjOux6mxgy6iOAolsSpbS1MDOU/E gX3AQFp9x+CDO4OxmjA6FXkgc3JwTvztVhNvoycVmbZXbzJYdS/e5tEtmz+vnqS5SzXM SM7CxSQGKszAxGPIoj/Q7AM26PO1nP7CTwfNE0XjaCRt8BUb1SjKTHm+nKtxriKeyQ5e XHSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nsMmiC7jhSKTFlhgcEpu4yxQzWbtu7ogv5Doohyfyhc=; b=KTaWyxpdMqaUfDTHdC7JwNUnZy8xD163JkzyGItMMowvK4G+pJ6+YYtl6rTCbk/18x 9dLSXNQY4qfNfuvid6wG3C2LBHQXZ8vviDuY1uYkNwVPnkl7KTjkWN+QhYJakWj4Blx6 LfGPEJebZyu351+uV2zHNg8x/ReH1M7KPT9ehZRL81tdM1Zl24YnDlFd0dmrqCI8E8VL TnjgXwtplc5aihpCNjjzp0Q4XnJiZUi1DvazvWGim2DWAXus1JANrSKyVcpYWE6gJAUH SI4XDETx6DyGkwZCmBZ9LBAIdJzc4S89uxTpHvWGJCvz1IvaGGbs/tuaa5d/Ve5fZQRA CIKA== X-Gm-Message-State: APjAAAX6TydtAzWYelL1aWySW68ZqtIgIVR0eqbybPhBEfpcmftnjapD R/1JeCcaWtlDiEZxgpMeui0D9BddhwLkYQ== X-Received: by 2002:a63:f64f:: with SMTP id u15mr8734681pgj.192.1555909461379; Sun, 21 Apr 2019 22:04:21 -0700 (PDT) Received: from localhost.localdomain ([132.237.175.246]) by smtp.gmail.com with ESMTPSA id y8sm16192332pgk.20.2019.04.21.22.04.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Apr 2019 22:04:20 -0700 (PDT) From: crag0715@gmail.com To: linux-usb@vger.kernel.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, hayeswang@realtek.com, mario_limonciello@dell.com, crag0715@gmail.com, "Crag.Wang" , "David S. Miller" , Simon Glass , Grant Grundler , Sean Paul , David Chen , Kai-Heng Feng , "Gustavo A. R. Silva" , Charles Hyde , Sebastian Andrzej Siewior , zhong jiang Subject: [PATCH v2 1/1] r8152: sync sa_family with the media type of network device Date: Mon, 22 Apr 2019 13:03:43 +0800 Message-Id: <20190422050344.24513-1-crag0715@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Crag.Wang" Without this patch the socket address family sporadically gets wrong value ends up the dev_set_mac_address() fails to set the desired MAC address. Signed-off-by: Crag.Wang --- drivers/net/usb/r8152.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 4c63b40d5e00..41fb39ce69c9 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -1225,6 +1225,8 @@ static int determine_ethernet_addr(struct r8152 *tp, struct sockaddr *sa) struct net_device *dev = tp->netdev; int ret; + sa->sa_family = dev->type; + if (tp->version == RTL_VER_01) { ret = pla_ocp_read(tp, PLA_IDR, 8, sa->sa_data); } else { -- 2.20.1