Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2222232yba; Mon, 22 Apr 2019 02:46:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqwoDD6MAfbrRrJO36M3d0/d/EEf0s04CAB1lgt2unptlUG+X8Kf8wR6iIDhmKmvBjNSYRxn X-Received: by 2002:a63:ea52:: with SMTP id l18mr4425386pgk.124.1555926401815; Mon, 22 Apr 2019 02:46:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555926401; cv=none; d=google.com; s=arc-20160816; b=UYT8lrWymppVHbO2OcBXKWbhP00Bx7ImT17R1nMyFH7EgzbS1DNCQA6fG6UMazMtto F9srXFpPz3wUSqKyEAxy76xm5UhhakJaq/kOkpe+wBCeBVqNbwXVhatXBirdWgWJxHEH Sa/TxGTP1zaYY2HZYrLwmfZk7N9pu/hni9r2QW2NMLf/yKWgDjuTi3Se4vdXS2ifdvu1 8Cs2lPbOY4Nvi7ah0HgVeMQ8gHSjOw6moiNoOEGQdKvbHvV08QGDFMYdA3U2OG1Yxx0G dCg55aEh7HVrTX9Z4ZakU3+LzPks9WFaiLDrt730ScnRD7u2Z/QvqY+cBxM1Mr37UnQJ GcMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=i0OprJEd7XY76fYikzNn1xipMj+e77bTw+A3G17ejho=; b=dXw1zhWFmVvO9jC+CyLxjfqro+NkyVoB9nbYDtGt+AIz/FOFBqIZFcimVn0cAuyqLR a81EHJrAqcte0/XFWQPSX8Ms3Hfb7cvp9CQJ3QMnCVa6Rv16yE7eezvaVRczxSOAFa4o Yixov1kSV2I1L9bf/a+f4ebzLonmDMAAO47GbDS6V050yUeF/k8p+dvTy/J2ZC1tOFYY U5mBZ0xHcjjRHe6GXVaHldmqSGHabHOOFkuNIW4BNAOXnQ+7e+QGpYRgVDGi+HTFS6w5 xhuqLb7meC0eAnZCNehvzwt3fbltA7uWGTRx7peYBceEfoSpYQX4ji+zsMcHLFnqHj1d 2h4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h15si11411018pgv.169.2019.04.22.02.46.26; Mon, 22 Apr 2019 02:46:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727012AbfDVI7Z (ORCPT + 99 others); Mon, 22 Apr 2019 04:59:25 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:52055 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725914AbfDVI7Z (ORCPT ); Mon, 22 Apr 2019 04:59:25 -0400 X-UUID: 06297fc90cdb44d286cbac5391cdd8bb-20190422 X-UUID: 06297fc90cdb44d286cbac5391cdd8bb-20190422 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 2119209235; Mon, 22 Apr 2019 16:59:20 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 22 Apr 2019 16:59:18 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 22 Apr 2019 16:59:19 +0800 Message-ID: <1555923559.2854.14.camel@mtksdaap41> Subject: Re: [PATCH v1 4/4] drm/mediatek: fix possible_crtcs From: YT Shen To: Frank Wunderlich CC: CK Hu , Philipp Zabel , David Airlie , Daniel Vetter , "Matthias Brugger" , , , , , Rob Herring , "Mark Rutland" , , chunhui dai , Ryder Lee , Bibby Hsieh Date: Mon, 22 Apr 2019 16:59:19 +0800 In-Reply-To: <20190416145848.11932-5-frank-w@public-files.de> References: <20190416145848.11932-1-frank-w@public-files.de> <20190416145848.11932-5-frank-w@public-files.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frank, On Tue, 2019-04-16 at 16:58 +0200, Frank Wunderlich wrote: > From: Ryder Lee > > without this patch there is purple stretched font on fbconsole > > source: http://forum.banana-pi.org/t/kernel-4-19-rc1-for-testers/6618/52 > > Signed-off-by: Ryder Lee > Tested-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 5d333138f913..c171b01f77e0 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -610,7 +610,7 @@ static int mtk_dpi_bind(struct device *dev, struct device *master, void *data) > drm_encoder_helper_add(&dpi->encoder, &mtk_dpi_encoder_helper_funcs); > > /* Currently DPI0 is fixed to be driven by OVL1 */ > - dpi->encoder.possible_crtcs = BIT(1); > + dpi->encoder.possible_crtcs = BIT(0)|BIT(1); This patch is not a good solution. The solution should find the components in the arrays to determine the correct crtcs, not just set all available bits. You see the problem because the hardware connections(BIT0) is not the same as driver reports(BIT1 changed to BIT0|BIT1, but BIT1 is not supported). Regards, yt.shen > > ret = drm_bridge_attach(&dpi->encoder, dpi->bridge, NULL); > if (ret) { > -- > 2.17.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek