Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2232217yba; Mon, 22 Apr 2019 03:01:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqzgWFEYIChbbfAArOb2qNYs4dH7BEdKx/CfV8UP1w850QwZB+XJckgBt8CIDBfrVGpb8GfN X-Received: by 2002:a62:75cd:: with SMTP id q196mr19488094pfc.70.1555927262473; Mon, 22 Apr 2019 03:01:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555927262; cv=none; d=google.com; s=arc-20160816; b=sNJSXeZtCNddTwjnN/vymFM18+TcinigrEtCngS/iAvtkwOObxZkLmLx4MDhFbYCBl WgYDbdkdwy/FpluMX3kMr8K9UFhf/Rl3zWC08UkUCuzOhpHezIyGfYEwVNibkL8QHKMW nAR+g0TgsxBvh+WrFFFSAE8lFo23fb6wAitvDTogLIhl751qpC5VkzFAEohRQzwEJrIp I+RLf8eC7h2aVPCU4nBeE+mAY0lQEY2ooi8DEOnTdkGCOtZPZze/99zqJwiL7fNTma4q nmw1N5A3lVGmeXpY0o+YkbiIFz131uX1DuMeorUenbTYUc8DrT7MAEOQbprnkPzqJgOU GQKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date:dkim-signature:dkim-filter; bh=gVN5PFdLqBPjOEas9IPy4XzmRXxWiBb42yRgJiJIe7I=; b=s1X1wX8ZK9dTKkGlWtDMpVA6rAXfdMWWJ59QVvPj3xNlfplXOHm2M5sH5Qv2uG8jLz NDWSEC7VzhSnjqJyVkqJCNmOuvfHWSO0HfWfimw/rX6ge5W4TRs/1YEvD200AY/LmTJS SdEHfmDcGYczaGuPLQQfvfsykBDPhY44qCABqTdbbv0cfXkewomR5PEDA11Zb32PcpoO aOch1Q3Fxmw94PJHGJqMn6NXAlVodyWcfsynv4yA3eG1VKeq45so5DpyYkPZOZd3Hlez Hgj95xZDwAH91JPRIvMfxlWigNZYL0SkAvVWtbn7dqtORKBqsPUDKkMc2/ysqJ/l0cIX UboQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zytor.com header.s=2019041745 header.b=FXpm5HYj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zytor.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e96si9800809plb.0.2019.04.22.03.00.47; Mon, 22 Apr 2019 03:01:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zytor.com header.s=2019041745 header.b=FXpm5HYj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zytor.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727012AbfDVJrx (ORCPT + 99 others); Mon, 22 Apr 2019 05:47:53 -0400 Received: from terminus.zytor.com ([198.137.202.136]:35909 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbfDVJrx (ORCPT ); Mon, 22 Apr 2019 05:47:53 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x3M9kHQr1583071 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 22 Apr 2019 02:46:17 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x3M9kHQr1583071 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019041745; t=1555926377; bh=gVN5PFdLqBPjOEas9IPy4XzmRXxWiBb42yRgJiJIe7I=; h=Date:From:Cc:Reply-To:In-Reply-To:References:To:Subject:From; b=FXpm5HYjwvG/Lt0tK7r4Y9sQIQyoXqw1sAG7+q06Unfc7XB5jHXTVBMTAeNfQqeFb zkHKR3km2taofW8BIPy13+iCtczW9R1Hn0xHJTw8pZpAfI7SJxhU5Vs27Ltzcav9cv DpYbZwOtPHRl7j+RmQM9UZkWEaIHoF+EkW2Ik+DxHljo1OINX1Xgz+vwO70qfV5xqq /jV0TS/XrA9OzErbmhc98wnrRKvKTiEs+0EYjVPznkG4U4h7ahB9uHhzGoJ3GyM/hO RNrhGAkKM/2qFV95CITMZyW+WHf454QbRU9D0fczgFHh5p/K1WMq1cSv7YK77cGZil nOwUTfJqTKtig== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x3M9kGGR1583068; Mon, 22 Apr 2019 02:46:16 -0700 Date: Mon, 22 Apr 2019 02:46:16 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Borislav Petkov Message-ID: Cc: thomas.lendacky@amd.com, dave.hansen@linux.intel.com, keescook@chromium.org, tglx@linutronix.de, x86@kernel.org, mingo@kernel.org, ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org, mingo@redhat.com, kirill.shutemov@linux.intel.com, hpa@zytor.com, bp@suse.de, jgross@suse.com, fanc.fnst@cn.fujitsu.com, bhe@redhat.com Reply-To: jgross@suse.com, bp@suse.de, fanc.fnst@cn.fujitsu.com, bhe@redhat.com, ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org, mingo@redhat.com, kirill.shutemov@linux.intel.com, hpa@zytor.com, mingo@kernel.org, dave.hansen@linux.intel.com, thomas.lendacky@amd.com, tglx@linutronix.de, keescook@chromium.org, x86@kernel.org In-Reply-To: <20190419141952.GE10324@zn.tnic> References: <20190419141952.GE10324@zn.tnic> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/boot: Disable RSDP parsing temporarily Git-Commit-ID: 36f0c423552dacaca152324b8e9bda42a6d88865 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=0.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DATE_IN_FUTURE_12_24,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, DKIM_VALID_EF autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 36f0c423552dacaca152324b8e9bda42a6d88865 Gitweb: https://git.kernel.org/tip/36f0c423552dacaca152324b8e9bda42a6d88865 Author: Borislav Petkov AuthorDate: Fri, 19 Apr 2019 15:40:14 +0200 Committer: Borislav Petkov CommitDate: Mon, 22 Apr 2019 11:36:43 +0200 x86/boot: Disable RSDP parsing temporarily The original intention to move RDSP parsing very early, before KASLR does its ranges selection, was to accommodate movable memory regions machines (CONFIG_MEMORY_HOTREMOVE) to still be able to do memory hotplug. However, that broke kexec'ing a kernel on EFI machines because depending on where the EFI systab was mapped, on at least one machine it isn't present in the kexec mapping of the second kernel, leading to a triple fault in the early code. Fixing this properly requires significantly involved surgery and we cannot allow ourselves to do that, that close to the merge window. So disable the RSDP parsing code temporarily until it is fixed properly in the next release cycle. Signed-off-by: Borislav Petkov Cc: Ard Biesheuvel Cc: Baoquan He Cc: Chao Fan Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: indou.takao@jp.fujitsu.com Cc: Ingo Molnar Cc: Juergen Gross Cc: kasong@redhat.com Cc: Kees Cook Cc: "Kirill A. Shutemov" Cc: msys.mizuma@gmail.com Cc: Thomas Gleixner Cc: Tom Lendacky Cc: x86-ml Link: https://lkml.kernel.org/r/20190419141952.GE10324@zn.tnic --- arch/x86/boot/compressed/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c index c0d6c560df69..5a237e8dbf8d 100644 --- a/arch/x86/boot/compressed/misc.c +++ b/arch/x86/boot/compressed/misc.c @@ -352,7 +352,7 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap, boot_params->hdr.loadflags &= ~KASLR_FLAG; /* Save RSDP address for later use. */ - boot_params->acpi_rsdp_addr = get_rsdp_addr(); + /* boot_params->acpi_rsdp_addr = get_rsdp_addr(); */ sanitize_boot_params(boot_params);